This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix: make fetching logs from fork efficient#4250
Open
area wants to merge 1 commit intoConsenSys-archive:developfrom
Open
fix: make fetching logs from fork efficient#4250area wants to merge 1 commit intoConsenSys-archive:developfrom
area wants to merge 1 commit intoConsenSys-archive:developfrom
Conversation
area
force-pushed
the
feat/forked-logs
branch
from
89bc7f3 to
bd1f941
Compare
area
changed the title
area
force-pushed
the
feat/forked-logs
branch
from
bd1f941 to
4a65345
Compare
area
changed the title
Contributor
|
Looks like a dplicate of #3692 Don't close this one, we'll evaluate the two approaches. |
area
force-pushed
the
feat/forked-logs
branch
from
be09b49 to
4a65345
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When querying a forked chain for events pre-fork, a request is currently sent for every block which is very inefficient if you're querying a large block range, and can cause requests to respond only after a very long time, making the ability to fork useless if such requests are required. This PR aims to batch all of those in to one request to the forked endpoint.