-
Notifications
You must be signed in to change notification settings - Fork 11
89 vale updates #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
89 vale updates #92
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Cursor Rules for docs-spelling-check | ||
|
|
||
| ## File Access Restrictions | ||
|
|
||
| **IMPORTANT**: Only modify files within these directories: | ||
| - `styles/config/` (and all subdirectories) | ||
| - `styles/Consensys/` (and all subdirectories) | ||
|
|
||
| **DO NOT** modify, edit, or create files in: | ||
| - `styles/Microsoft/` (external package - changes will be lost on sync) | ||
| - `styles/proselint/` (external package - changes will be lost on sync) | ||
| - `styles/write-good/` (external package - changes will be lost on sync) | ||
| - Any other directories outside of `styles/config/` and `styles/Consensys/` | ||
|
|
||
| ## Workflow Guidelines | ||
|
|
||
| 1. **Read-only access** to external packages: You may read files in `styles/Microsoft/`, `styles/proselint/`, and `styles/write-good/` for reference, but never modify them. | ||
|
|
||
| 2. **Allowed modifications**: | ||
| - Files in `styles/config/` (including `ignore.yml`, vocabulary files, etc.) | ||
| - Files in `styles/Consensys/` (all YAML style files) | ||
|
|
||
| 3. **Before making changes**: Always verify the file path is within the allowed directories. | ||
|
|
||
| 4. **If asked to modify restricted files**: Politely decline and explain that those are external packages that will be overwritten on sync. | ||
|
|
||
| ## Context | ||
|
|
||
| This repository uses Vale for linting. The `styles/config/` directory contains project-specific configuration and vocabulary files. The `styles/Consensys/` directory contains custom style rules. The other style directories (`Microsoft/`, `proselint/`, `write-good/`) are external packages that are synced and should not be modified. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,16 +20,33 @@ swap: | |
| 'On-chain': 'Onchain' | ||
| 'on chain': 'onchain' | ||
| 'On chain': 'Onchain' | ||
| # tested but this apparently failed to be handled with [Oo]ffchain in accept | ||
| 'off-chain': 'offchain' | ||
| 'Off-chain': 'Offchain' | ||
| 'off chain': 'offchain' | ||
| 'Off chain': 'Offchain' | ||
| # this may be handled just by putting zkEVM into accept {need to test} | ||
| 'ZK EVM': '"zkEVM"' | ||
| 'ZKEVM': '"zkEVM"' | ||
| 'ZK-EVM': '"zkEVM"' | ||
| 'zk-EVM': '"zkEVM"' | ||
| 'zk EVM': '"zkEVM"' | ||
| # MetaMask Embedded Wallets - enforce proper capitalization | ||
| 'metamask embedded wallets': '"MetaMask Embedded Wallets"' | ||
| 'MetaMask embedded wallets': '"MetaMask Embedded Wallets"' | ||
| 'MetaMask Embedded wallets': '"MetaMask Embedded Wallets"' | ||
| 'metamask Embedded Wallets': '"MetaMask Embedded Wallets"' | ||
| # MetaMask - enforce proper capitalization | ||
| "metamask": "MetaMask" | ||
| "Metamask": "MetaMask" | ||
| # Embedded Wallets - enforce proper capitalization | ||
| "embedded wallets": "Embedded Wallets" | ||
| "embedded Wallets": "Embedded Wallets" | ||
| "Embedded wallets": "Embedded Wallets" | ||
| # Mastercard - enforce proper capitalization | ||
| 'mastercard': '"Mastercard"' | ||
| # WalletConnect - enforce proper capitalization | ||
| 'walletconnect': '"WalletConnect"' | ||
| 'Walletconnect': '"WalletConnect"' | ||
| # Shamir's - enforce proper capitalization | ||
| shamir: "Shamir's" | ||
| "shamir's": "Shamir's" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing substitution rule for capitalized "Shamir" without apostropheLow Severity The substitution rules only cover |
||
| # Polkadot - enforce proper capitalization | ||
| "polkadot": "Polkadot" | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed separator may break vale-action file parsing
Medium Severity
The
separatorparameter was removed from the vale-action configuration, but the input format has changed from comma-separated paths to newline-separated file paths (viaoutput_separator: '\n'from changed-files). The old configuration explicitly setseparator: ","to tell vale-action how to parse multiple files. Without this parameter, vale-action may not correctly parse the newline-separatedall_changed_filesoutput, potentially causing the linter to fail or process files incorrectly.