-
Notifications
You must be signed in to change notification settings - Fork 493
test: handle gnark-crypto not returning malleable signatures anymore #1601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+32
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38a0bc0 to
caf2e18
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ThomasPiellard
previously approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Consensys/gnark-crypto#725 gnark-crypto prevents returning ECDSA signatures with large s (>(mod-1)/2), but we're testing the mismatch case in the precompile tests here.
Handle it manually now and explicitly create large s in tests.
This PR currently depends on a gnark-crypto branch as the change isn't merged yet. When corresponding gnark-crypto PR is merged then also should update dependency here to gnark-crypto@master.
Type of change
How has this been tested?
Checklist:
golangci-lintdoes not output errors locallyNote
Update tests to manually create large-S ECDSA signatures for ecrecover, remove ECDSA benchmarks, and bump gnark-crypto dependency.
ecrecover):shandling intestRoutineECRecoverby flippingvand makings = mod - swhen needed.Strictlogic and update test cases to use the new helper; add second valid assignment and extra failure-path checks.ecdsa_secpr_test.go.github.com/consensys/gnark-cryptotov0.19.3-0.20251115174214-022ec58e8c19ingo.modandgo.sum.Written by Cursor Bugbot for commit bd6ded8. This will update automatically on new commits. Configure here.