Open
Conversation
… into perf/gkr/factor-eq
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
This reverts commit 3ce291a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

When a Zero-Check has only one "evaluation point", at every round a prefix of the eq term (containing an indeterminate) can be factored out and computed by the verifier. This reduces the number of Fiat-Shamir hashes benefitting the verifier directly (at the cost of a trivial amount of extra work to compute the eq terms at the end of a sum-check run). For the prover, 1/d+1 of the work each round will be saved.
BenchmarkGkrPoseidon2 was benchmarked on an hpc6a.48xlarge machine with the following results:
Note
High Risk
Touches core GKR proving/verification and transcript-binding behavior; any mistake could break proof soundness or cause verifier/prover divergence despite being a performance-focused change.
Overview
Introduces
constraint.GkrSingleSourceZeroCheckLeveland wires it into schedule serialization (marshal.go) and level dispatch in generated and curve-specific GKR backends.Implements a new single-source zerocheck sumcheck variant that factors out the
eqpolynomial (precomputing suffixeqtables and adjusting prover/verifier round polynomials), while refactoring shared zerocheck setup intozeroCheckBaseand consolidating verifier setup logic.Also changes
gateEvaluatorPoolfrom a map-backed set to a slice-based stack for cheaper reuse, and moves the bulky zerocheck/sumcheck claim implementations out ofgkr.gointosumcheck.gotemplates/generated code.Written by Cursor Bugbot for commit ed90cd5. This will update automatically on new commits. Configure here.