Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2335 +/- ##
============================================
+ Coverage 60.93% 60.97% +0.03%
Complexity 1619 1619
============================================
Files 436 436
Lines 17363 17379 +16
Branches 1908 1912 +4
============================================
+ Hits 10580 10596 +16
Misses 6123 6123
Partials 660 660
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
kyzooghost
reviewed
Feb 10, 2026
| revert PauseUnavailableDueToCooldown(pauseExpiryTimestamp + COOLDOWN_DURATION); | ||
| unchecked { | ||
| uint256 _remainingCooldown = _cooldownEnd - block.timestamp; | ||
| if (_remainingCooldown > COOLDOWN_DURATION) { |
Contributor
There was a problem hiding this comment.
not sure about the triple-nested if-else blocks 😅
Contributor
There was a problem hiding this comment.
should we use early returns instead?
if security_council ... -> early return
if past_cooldown ... -> early return
if in_pause_window ... -> early return
revert...
Collaborator
Author
There was a problem hiding this comment.
you still need to set the pause and emit and adding another function just for that felt messier.
kyzooghost
previously approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #
Checklist
Note
High Risk
Changes core pausing/cooldown behavior and adds new storage/state (
nonSecurityCouncilCooldownEnd, per-type expiries) in an upgradeable security-critical contract, so incorrect logic or storage assumptions could lock/unlock functionality unexpectedly.Overview
Refactors
PauseManagerto replace the single globalpauseExpiryTimestampwith per-PauseTypeexpiry tracking (pauseTypeExpiryTimestamps) and a newnonSecurityCouncilCooldownEndthat enforces a pause window (additional types can be paused during the firstPAUSE_DURATION) followed by a cooldown where non-security-council pausing is blocked.Adds explicit security council indefinite pausing semantics:
pauseByTypebySECURITY_COUNCIL_ROLEsets expiry touint256.maxand emitsPausedIndefinitely, whileunPauseByTypenow blocks non-SC from unpausing indefinite pauses viaOnlySecurityCouncilCanUnpauseIndefinitePause. IntroducesresetNonSecurityCouncilCooldownEnd()(SC-only) and emitsNonSecurityCouncilCooldownEndReset.Updates hardhat tests and yield-manager controls to match new timing/emit behavior and adds a short doc (
pause-by-type-flow.txt); updatesLineaRollupV7.1.abito reflect the new pause manager surface (new getter/event/function/error).Written by Cursor Bugbot for commit c374a2c. This will update automatically on new commits. Configure here.