Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2346 +/- ##
============================================
+ Coverage 60.93% 61.40% +0.47%
Complexity 1619 1619
============================================
Files 436 438 +2
Lines 17363 17220 -143
Branches 1908 1905 -3
============================================
- Hits 10580 10574 -6
+ Misses 6123 5994 -129
+ Partials 660 652 -8
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
kyzooghost
approved these changes
Feb 10, 2026
kyzooghost
previously approved these changes
Feb 10, 2026
| ], | ||
| "name": "UnPausedDueToExpiry", | ||
| "type": "event" | ||
| }, |
There was a problem hiding this comment.
ABI file has wrong indexed flag for event parameter
Medium Severity
The UnPausedDueToExpiry event in the ABI file has "indexed": false for the pauseType parameter, but the Solidity interface declares it as PauseType indexed pauseType. This mismatch means any off-chain client or monitoring tool using this ABI will fail to correctly decode or filter UnPausedDueToExpiry events, since the actual pauseType value will be in topics[1] while the client expects it in the event data blob.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR implements issue(s) #
Checklist
Note
High Risk
Touches core rollup/messaging/bridge upgrade paths and pausing behavior; incorrect version gating, slot clearing, or pause timing could break upgrades or emergency controls in production.
Overview
Hardens upgrade/initialization flows across core contracts by introducing
InitializationVersionCheckand usingonlyInitializedVersion(0)+reinitializer(N)inTokenBridge,L2MessageService, andLineaRollup, replacing prior proxy-admin gating and adding a newInitializedVersionWrongcustom error.Refactors reentrancy and upgrade-safety mechanics: the transient reentrancy guard now uses an explicit transient-storage key via
tload/tstore, and upgrade reinitializers (reinitializeV3) clear legacy OZ reentrancy slots with an explicit guard (revertReentrantCallif legacy slot indicates ENTERED). Multiple externally callable entrypoints were widened fromexternaltopublicto support inheritance/overrides.Reworks pausing semantics with per-type expiry (
pauseTypeExpiryTimestamps), a new non-security-council pause window + cooldown (nonSecurityCouncilCooldownEnd), updated durations (48h/48h), and new events/errors (PausedIndefinitely,NonSecurityCouncilCooldownEndReset,OnlySecurityCouncilCanUnpauseIndefinitePause) plus a new SC-onlyresetNonSecurityCouncilCooldownEndhook; tests and docs were updated accordingly. Also updates rollup init event (LineaRollupBaseInitialized) to includegenesisShnarf, adds a new LineaRollup ABI artifact (LineaRollupV7.1.abi), and expands test helpers to read/write storage slots for upgrade simulation.Written by Cursor Bugbot for commit 4aac3da. This will update automatically on new commits. Configure here.