Skip to content

Enable limitless/ZkCounter for all acceptance tests#2351

Open
gauravahuja wants to merge 3 commits intomainfrom
gauravahuja/at_zkcounter
Open

Enable limitless/ZkCounter for all acceptance tests#2351
gauravahuja wants to merge 3 commits intomainfrom
gauravahuja/at_zkcounter

Conversation

@gauravahuja
Copy link
Contributor

@gauravahuja gauravahuja commented Feb 10, 2026

This PR implements issue(s) #2249

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

Note

Low Risk
Changes are limited to acceptance-test CLI configuration and should only affect test behavior/coverage, with low risk to production code.

Overview
Updates Linea sequencer acceptance-test defaults to run with --plugin-linea-limitless-enabled=true and use moduleLimitsLimitless.toml as the standard module-limits configuration.

Tests that validate strict/excluded-precompile behavior (TransactionTraceLimitTest, ExcludedPrecompilesTest) now explicitly disable limitless and point to the appropriate strict/no-limits module limit files to preserve their expected assertions.

Written by Cursor Bugbot for commit 58087dc. This will update automatically on new commits. Configure here.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 10.18%. Comparing base (0d5cce9) to head (58087dc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2351       +/-   ##
=============================================
- Coverage     61.13%   10.18%   -50.96%     
=============================================
  Files           436      436               
  Lines         17362    17362               
  Branches       1908     1908               
=============================================
- Hits          10615     1769     -8846     
- Misses         6088    15593     +9505     
+ Partials        659        0      -659     
Flag Coverage Δ *Carryforward flag
hardhat 97.89% <ø> (ø) Carriedforward from ece00f7
kotlin 0.00% <ø> (-56.87%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.
see 290 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauravahuja gauravahuja force-pushed the gauravahuja/at_zkcounter branch from be2b6b8 to d967374 Compare February 10, 2026 19:19
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we @Disabled by default all non limitless AT @fab-10 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real question is if there are still excluded precompiles with the ZkCounter, the if yes, the test should be adapted to work with it, otherwise since no more relevant it can be disable or removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we @Disabled by default all non limitless AT @fab-10 ?

Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said in response so @letypequividelespoubelles, the 2 test still on the ZkTracer either should be adapted to work with the ZkCounter or if not relevant anymore, disabled or removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real question is if there are still excluded precompiles with the ZkCounter, the if yes, the test should be adapted to work with it, otherwise since no more relevant it can be disable or removed

@letypequividelespoubelles
Copy link
Contributor

As I said in response so @letypequividelespoubelles, the 2 test still on the ZkTracer either should be adapted to work with the ZkCounter or if not relevant anymore, disabled or removed

The ZkCounter does count all the precompiles limits, as the ZkTracer does. So the exact same test but with a ZkCounter instead of a ZkCounter should work, no ?

@fab-10
Copy link
Contributor

fab-10 commented Feb 13, 2026

As I said in response so @letypequividelespoubelles, the 2 test still on the ZkTracer either should be adapted to work with the ZkCounter or if not relevant anymore, disabled or removed

The ZkCounter does count all the precompiles limits, as the ZkTracer does. So the exact same test but with a ZkCounter instead of a ZkCounter should work, no ?

So the test is still relevant, and should be adapted to work with the limitless mode

@gauravahuja
Copy link
Contributor Author

@letypequividelespoubelles I don't have much context on the tests so could you help adapt them to limitless mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants