[Fix] - Add sanity check for final forced tx number#2379
Open
thedarkjester wants to merge 1 commit intofeat/tx-gatewayfrom
Open
[Fix] - Add sanity check for final forced tx number#2379thedarkjester wants to merge 1 commit intofeat/tx-gatewayfrom
thedarkjester wants to merge 1 commit intofeat/tx-gatewayfrom
Conversation
VGau
approved these changes
Feb 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/tx-gateway #2379 +/- ##
==================================================
Coverage 61.70% 61.70%
Complexity 1618 1618
==================================================
Files 440 440
Lines 17356 17358 +2
Branches 1945 1946 +1
==================================================
+ Hits 10709 10711 +2
Misses 5995 5995
Partials 652 652
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #
Checklist
Note
Low Risk
Small, additive validation that only introduces an earlier revert in finalization when forced-transaction state is inconsistent; covered by a new test.
Overview
Adds a sanity check during
finalizeBlocksto ensure that whenfinalForcedTransactionNumberis non-zero, the correspondingforcedTransactionRollingHashesentry is present; otherwise it reverts with new custom errorMissingRollingHashForForcedTransactionNumber.Updates the forced-transactions interface to expose this new error and adds a Hardhat test covering the new revert path when finalization references a forced transaction number without a stored rolling hash.
Written by Cursor Bugbot for commit 69b4997. This will update automatically on new commits. Configure here.