Skip to content

[Fix] - Add sanity check for final forced tx number#2379

Open
thedarkjester wants to merge 1 commit intofeat/tx-gatewayfrom
fix/add-DiD-check
Open

[Fix] - Add sanity check for final forced tx number#2379
thedarkjester wants to merge 1 commit intofeat/tx-gatewayfrom
fix/add-DiD-check

Conversation

@thedarkjester
Copy link
Collaborator

@thedarkjester thedarkjester commented Feb 13, 2026

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

Note

Low Risk
Small, additive validation that only introduces an earlier revert in finalization when forced-transaction state is inconsistent; covered by a new test.

Overview
Adds a sanity check during finalizeBlocks to ensure that when finalForcedTransactionNumber is non-zero, the corresponding forcedTransactionRollingHashes entry is present; otherwise it reverts with new custom error MissingRollingHashForForcedTransactionNumber.

Updates the forced-transactions interface to expose this new error and adds a Hardhat test covering the new revert path when finalization references a forced transaction number without a stored rolling hash.

Written by Cursor Bugbot for commit 69b4997. This will update automatically on new commits. Configure here.

@thedarkjester thedarkjester requested a review from a team as a code owner February 13, 2026 11:02
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.70%. Comparing base (2fc6ea9) to head (69b4997).

Additional details and impacted files
@@                Coverage Diff                 @@
##             feat/tx-gateway    #2379   +/-   ##
==================================================
  Coverage              61.70%   61.70%           
  Complexity              1618     1618           
==================================================
  Files                    440      440           
  Lines                  17356    17358    +2     
  Branches                1945     1946    +1     
==================================================
+ Hits                   10709    10711    +2     
  Misses                  5995     5995           
  Partials                 652      652           
Flag Coverage Δ *Carryforward flag
hardhat 98.00% <100.00%> (+<0.01%) ⬆️
kotlin 57.08% <ø> (ø) Carriedforward from 2fc6ea9

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
contracts/src/rollup/LineaRollupBase.sol 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments