Skip to content

Ensure ADK runners are closed after executions #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Ensure ADK runners are closed after executions #94

wants to merge 1 commit into from

Conversation

contextablemark
Copy link
Member

Summary

  • ensure the ADK middleware always awaits Runner.close so toolsets are cleaned up after executions
  • add regression tests that assert the runner is closed on both successful runs and error paths

Testing

  • PYTHONPATH=python-sdk:typescript-sdk/integrations/adk-middleware/python/src pytest typescript-sdk/integrations/adk-middleware/python/tests/test_adk_agent.py (fails: ModuleNotFoundError: No module named 'google')

https://chatgpt.com/codex/tasks/task_e_68e96a283af883218ee21ed01db50545

@contextablemark
Copy link
Member Author

Merged into upstream

@contextablemark contextablemark deleted the codex/address-issue-516-in-ag-ui branch October 14, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@contextablemark