Skip to content

Build for amd64 and arm64 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andersonshatch
Copy link

Would be nice to have an arm image published for Apple Silicon usage.
I'm not sure if this will work as is with the build then push approach used -- presumably because of signing things -- but hard to test.

@jason-at-contrast
Copy link
Collaborator

When you do a build for the container, you can do this:
docker build --platform linux/arm64/v8 -t contrast/mcp-contrast .
Which removes the warning that you see in docker and also builds it for the latest silicon chip "v8"

@jason-at-contrast
Copy link
Collaborator

When you do a build for the container, you can do this: docker build --platform linux/arm64/v8 -t contrast/mcp-contrast . Which removes the warning that you see in docker and also builds it for the latest silicon chip "v8"

image

@andersonshatch
Copy link
Author

Yes, we should do that in the pipeline as folks will pull the public image to avoid building. Hence this PR.

Copy link
Collaborator

@jason-at-contrast jason-at-contrast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the checks that are failing, this looks good and should support apple's silicon's chipset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants