Support for Olog templates #3202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrahamwolk
reviewed
Dec 2, 2024
...ogbook/olog/ui/src/main/java/org/phoebus/logbook/olog/ui/write/LogEntryEditorController.java
Outdated
Show resolved
Hide resolved
...ogbook/olog/ui/src/main/java/org/phoebus/logbook/olog/ui/write/LogEntryEditorController.java
Outdated
Show resolved
Hide resolved
| RequestTooLarge=Total file size exceeds limit, selected file(s) not added. | ||
| Reply=Reply | ||
| ReplyToLogEntry=Reply To Log Entry | ||
| SaveAsTemplate=Save as template |
Collaborator
There was a problem hiding this comment.
Following the capitalization that seems to be used for the labels, template should probably start with a capital T: Save as Template.
Collaborator
Author
|
@shroffk, would you have some time to give this a glance? |
shroffk
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Olog editor view user is presented with a ComboBox from which a
LogTemplatemay be selected. The ComboBox is enhanced with an AutocompleteMenu to facilitate selection.LogTemplates require server side support, see latest changes in https://github.com/Olog/phoebus-olog.This PR also contains some refactoring to reduce code duplication.