Skip to content

Conversation

@abrahamwolk
Copy link
Collaborator

This pull request adds the Phoebus documentation (if it has been built, by for example running mvn -Dsphinx -Nverify in the phoebus source directory) to the Phoebus package that is created when building phoebus-product using maven.

The intention is to facilitate the inclusion of the documentation when deploying the built Phoebus package.

If the documentation has not been built, then it is not included.

Copy link
Collaborator

@georgweiss georgweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this seems to do the right thing - i.e. to include out put of docs/build/html - I'm not sure if a mvn clean should delete the contents of docs/build.

@shroffk, can you share your input? This PR is about being able to include the output of docs build into the tar ball in phoebus-product/target.

@abrahamwolk
Copy link
Collaborator Author

abrahamwolk commented Dec 19, 2024

I'm not sure if a mvn clean should delete the contents of docs/build.

Do you mean that with this pull request, running mvn clean in phoebus-product deletes the contents of ../docs/build/html? If so, I don't think it does: running mvn clean in phoebus-product removes only the directory target, as far as I can see.

@georgweiss georgweiss self-requested a review December 20, 2024 07:20
@shroffk shroffk merged commit b180e11 into master Dec 26, 2024
2 checks passed
@abrahamwolk abrahamwolk deleted the CSSTUDIO-2487 branch January 7, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants