Skip to content

Conversation

@0marSalah
Copy link
Member

No description provided.

@0marSalah 0marSalah self-assigned this Sep 5, 2025
@vercel
Copy link

vercel bot commented Sep 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
dev.linked-claims-author Ready Ready Preview Comment Sep 5, 2025 0:43am
linked-claims-author Ready Ready Preview Comment Sep 5, 2025 0:43am
linked-claims-author-3teh Ready Ready Preview Comment Sep 5, 2025 0:43am
linked-claims-author-73r1 Ready Ready Preview Comment Sep 5, 2025 0:43am
linked-claims-author-8dp5 Ready Ready Preview Comment Sep 5, 2025 0:43am
linked-claims-author-gpm4 Ready Ready Preview Comment Sep 5, 2025 0:43am
linked-claims-author-ltir Canceled Canceled Sep 5, 2025 0:43am
linked-claims-author-mobile Ready Ready Preview Comment Sep 5, 2025 0:43am
linked-claims-author-t3 Ready Ready Preview Comment Sep 5, 2025 0:43am

// Create / load appInstanceDid for this client
const { did: appInstanceDid } = await getOrCreateAppInstanceDid()

// Initialize exchange session with appInstanceDid
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why store the app instance DID?

Copy link
Member Author

@0marSalah 0marSalah Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically i dont, i just use it to get it, thats cuz its already created on app load, but u r totally right i should use the one that in localstorage instead.

}

// Prepare LCW deep link
const chapiRequest = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to use the query from Step 4 of https://codeberg.org/interop-alliance/ops/issues/1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually the same query we’re already using in resume-author (https://github.com/Cooperation-org/Resume-Author/blob/41f169e3e1b711696c8c14627d11dfde7791e0fe/src/pages/LoginScanStep.tsx#L36
).
But since in LinkedCreds I need to run it on the server, that means we’ll have to do the same across all apps. Just wanted to confirm that’s the right approach.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I see ok. n/m, carry on.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm, I’m not sure I understood, do you mean I should keep the query as it is and not change anything, or should I update it in LinkedCreds and then make the same change across all apps?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just meant - never mind, ignore my comment

@0marSalah 0marSalah merged commit 730ee2c into dev Sep 22, 2025
10 checks passed
@0marSalah 0marSalah deleted the add-was-login-page branch September 22, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants