-
Notifications
You must be signed in to change notification settings - Fork 3
feat: implement zcap login page #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| // Create / load appInstanceDid for this client | ||
| const { did: appInstanceDid } = await getOrCreateAppInstanceDid() | ||
|
|
||
| // Initialize exchange session with appInstanceDid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why store the app instance DID?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically i dont, i just use it to get it, thats cuz its already created on app load, but u r totally right i should use the one that in localstorage instead.
| } | ||
|
|
||
| // Prepare LCW deep link | ||
| const chapiRequest = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll want to use the query from Step 4 of https://codeberg.org/interop-alliance/ops/issues/1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually the same query we’re already using in resume-author (https://github.com/Cooperation-org/Resume-Author/blob/41f169e3e1b711696c8c14627d11dfde7791e0fe/src/pages/LoginScanStep.tsx#L36
).
But since in LinkedCreds I need to run it on the server, that means we’ll have to do the same across all apps. Just wanted to confirm that’s the right approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh I see ok. n/m, carry on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmm, I’m not sure I understood, do you mean I should keep the query as it is and not change anything, or should I update it in LinkedCreds and then make the same change across all apps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just meant - never mind, ignore my comment
No description provided.