-
Notifications
You must be signed in to change notification settings - Fork 136
Feat: update serverless-offline for s3 and sqs to support serverless v4 #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@silouone Hello, is it possible to get a review? |
Hello @silouone any ETA for this to be reviewed & merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Thanks for taking interest and the PR, and sorry for the long wait without answers.
The technical approach looks ok and correctly implements serverless v4 compatibility and the new logging system.
I would need to try it out on our internal stack since we heavily required on serveless, it would be a good use case to test that out.
also please consider this feedback:
- Please squash commits into 2-3 logical units.
- "feat: update to serverless v4 plugin API"
- "test: improve integration test reliability"
- "chore: update dependencies and version bumps"
Or else.
- Please consider the few feedback I made about log being potentially
undefined
and support for that. - Please add doculmentation for this migration, after #installation:
Migrating from v7 to v8
This version requires Serverless Framework v4 and serverless-offline v14.4.0+.
Breaking Changes
- Requires
serverless-offline: "^14.4.0 || >=14"
- Uses new Serverless v4 plugin API for logging
- Node.js 18+ required
Upgrade Steps
- Update
serverless
to v4:npm install serverless@^4.0.0
- Update
serverless-offline
to v14.4.0+:npm install serverless-offline@^14.4.0
- Update this plugin:
npm install serverless-offline-s3@^8.0.0
@silouone thanks a lot for your review. I really appreciate it. I will take a look at the provided feedback. |
9253d6b
to
24dd7e0
Compare
@silouone Thank you for the thorough review. I’ve carefully addressed all the comments. |
Hi, |
Official documentation: https://www.serverless.com/framework/docs/guides/plugins/cli-output
Connected with issue #263