Field: remove uncallable conversion operator for Array and Table #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like clang gcc9 diagnoses the declaration when -Wclass-conversion is enabled. This prevents building applications that use AMQP-CPP with -Werror. Replace the uncallable overload with a test in the base class method that returns the proper value when the source value is the destination type. Signed-off-by: Peter A. Bigot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like clang gcc9 diagnoses the declaration when -Wclass-conversion is
enabled. This prevents building applications that use AMQP-CPP with
-Werror.
Replace the uncallable overload with a test in the base class method
that returns the proper value when the source value is the destination
type.
Signed-off-by: Peter A. Bigot [email protected]