Allow user to provide an alternative Authentication mechanism #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifications to login for supplying a custom security mechanism
Modify constructor comment for consistency
3 tasks
EmielBruijntjes
requested changes
May 4, 2022
Member
EmielBruijntjes
left a comment
EmielBruijntjes
left a comment
There was a problem hiding this comment.
I don't understand the change, and we need (at least) more in-code documentation to explain to users why they have to pass a username, password, mechanism and response.
| * @param response | ||
| */ | ||
| Login(const char *user, const char *password, const char *mechanism, const char *response) | ||
| : _user(user), _password(password), _mechanism(mechanism), _response(response) {} |
Member
There was a problem hiding this comment.
Can you add more in-code documentation? I don't understand the use case where it is up to the caller to supply a username, password, mechanism and response. What sort of values is one supposed to pass here?
Login mylogin("my-username", "my-password", "my-special-login-mechanism", "bla bla bla");Is this permitted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modifications to login.h and connectionstartframe.h allow a user to optionally provide an authentication mechanism other than the default PLAIN mechanism (username and password).