Refactoring libboostasio (part 1)#553
Open
paolopas wants to merge 6 commits intoCopernicaMarketingSoftware:masterfrom
Open
Refactoring libboostasio (part 1)#553paolopas wants to merge 6 commits intoCopernicaMarketingSoftware:masterfrom
paolopas wants to merge 6 commits intoCopernicaMarketingSoftware:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the result of the initial factorization of #550 (hence it's first child).
After each commit included in the PR I checked that there were no regressions, having more revisions will make the review easier. If @zerodefect thinks it's useful I can merge them into a single revision for the merge.
io_contex::strandheader, comments cleanupdeadline_timernull_buffers, this made it necessary to convert theasync_read_some/async_write_sometoasync_waitand consequently also the callback prototype (fortunately); Furthermore, these methods never return aboost::asio::error::would_blockerror if the socket is non-blocking.