fix(core): addressing issue with headers not being sent to run agent #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Slaton <[email protected]>
Signed-off-by: Tyler Slaton <[email protected]>
mme
reviewed
Sep 25, 2025
Contributor
mme
left a comment
mme
left a comment
There was a problem hiding this comment.
Great solution & nice tests!
We need to also apply the headers in updateRuntimeConnection when creating ProxiedCopilotRuntimeAgent and we can remove setting headers in connectAgent and runAgent
| this.localAgents = this.assignAgentIds(agents); | ||
| this.applyHeadersToAgents(this.localAgents); | ||
| this._agents = { ...this.localAgents, ...this.remoteAgents }; | ||
| this.applyHeadersToAgents(this._agents); |
Contributor
There was a problem hiding this comment.
Applying to this._agents should be enough (it contains all agents)
packages/core/src/core.ts
Outdated
| } | ||
| this.applyHeadersToAgent(agent); | ||
| this._agents = { ...this.localAgents, ...this.remoteAgents }; | ||
| this.applyHeadersToAgents(this._agents); |
Contributor
There was a problem hiding this comment.
This is not needed here, since we are adding an agent and we just want to apply headers to this particular agent
| this.headers = headers; | ||
| this.applyHeadersToAgents(this.localAgents); | ||
| this.applyHeadersToAgents(this.remoteAgents); | ||
| this.applyHeadersToAgents(this._agents); |
Contributor
There was a problem hiding this comment.
this.applyHeadersToAgents(this._agents) is enough
Signed-off-by: Tyler Slaton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.