Skip to content

Use localhost to ping server if server binds to 0.0.0.0 #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kripergvg wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −8
Open

Use localhost to ping server if server binds to 0.0.0.0 #542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions MCPForUnity/Editor/Services/Transport/Transports/WebSocketTransportClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,16 +682,18 @@ private static Uri BuildWebSocketUri(string baseUrl)
throw new InvalidOperationException($"Invalid MCP base URL: {baseUrl}");
}

string scheme = httpUri.Scheme.Equals("https", StringComparison.OrdinalIgnoreCase) ? "wss" : "ws";
string builder = $"{scheme}://{httpUri.Authority}";
if (!string.IsNullOrEmpty(httpUri.AbsolutePath) && httpUri.AbsolutePath != "/")
{
builder += httpUri.AbsolutePath.TrimEnd('/');
}
// Replace 0.0.0.0 with localhost for client connections
// 0.0.0.0 is only valid for server binding, not client connections
string host = httpUri.Host == "0.0.0.0" ? "localhost" : httpUri.Host;

builder += "/hub/plugin";
var builder = new UriBuilder(httpUri)
{
Scheme = httpUri.Scheme.Equals("https", StringComparison.OrdinalIgnoreCase) ? "wss" : "ws",
Host = host,
Path = httpUri.AbsolutePath.TrimEnd('/') + "/hub/plugin"
};

return new Uri(builder);
return builder.Uri;
}
}
}