Skip to content

Add Dolby Vision "Source levels metadata" setting #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
quietvoid wants to merge 2 commits into from
Closed

Add Dolby Vision "Source levels metadata" setting #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bae9d6
[Settings] Add Dolby Vision "Source levels metadata" setting
quietvoid Nov 2, 2025
f822eb6
[AMLCodec] Set dolby_vision_use_source_meta_levels kernel param
quietvoid Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion addons/resource.language.en_gb/resources/strings.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8836,7 +8836,19 @@ msgctxt "#14427"
msgid "Player-Led"
msgstr ""

#empty strings from id 14428 to 15010
#. Title of Dolby Vision Display Led Source Levels Metadata setting
#: system/settings/settings.xml
msgctxt "#14428"
msgid "Source levels metadata"
msgstr ""

#. Help text for setting "Source levels metadata" of label #14428
#: system/settings/settings.xml
msgctxt "#14429"
msgid "When using Display Led (DV-Std), send the source's levels Metadata, otherwise send then Dolby Vision engines altered levels metadata to the display."
msgstr ""

#empty strings from id 14430 to 15010

#: xbmc/music/MusicDatabase.cpp
#: xbmc/video/VideoDatabase.cpp
Expand Down
10 changes: 10 additions & 0 deletions system/settings/settings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3902,6 +3902,16 @@
</constraints>
<control type="spinner" format="string" />
</setting>
<setting id="coreelec.amlogic.dolbyvision.std.sourcelevelsmetadata" type="boolean" label="14428" help="14429" parent="coreelec.amlogic.dolbyvisionled">
<requirement>HAVE_AMCODEC</requirement>
<visible>false</visible>
<level>2</level>
<default>false</default>
<control type="toggle" />
<dependencies>
<dependency type="visible" setting="coreelec.amlogic.dolbyvisionled" operator="is">0</dependency>
</dependencies>
</setting>
</group>
</category>
<category id="cache" label="439" help="36399">
Expand Down
4 changes: 4 additions & 0 deletions xbmc/cores/VideoPlayer/DVDCodecs/Video/AMLCodec.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2040,6 +2040,10 @@ bool CAMLCodec::OpenDecoder(CDVDStreamInfo &hints, enum ELType dovi_el_type)
{
dolby_vision_flags.Set(dolby_vision_flags.Get<unsigned int>().value() & ~(FLAG_FORCE_DV_LL));
dolby_vision_ll_policy.Set(DOLBY_VISION_LL_DISABLE);

CSysfsPath dolby_vision_source_meta_levels{"/sys/module/amdolby_vision/parameters/dolby_vision_use_source_meta_levels"};
dolby_vision_source_meta_levels
.Set(CServiceBroker::GetSettingsComponent()->GetSettings()->GetBool(CSettings::SETTING_COREELEC_AMLOGIC_DV_STD_SOURCE_LEVELS_METADATA));
}
}

Expand Down
1 change: 1 addition & 0 deletions xbmc/settings/Settings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,7 @@ class CSettings : public CSettingsBase, public CSettingCreator, public CSettingC
static constexpr auto SETTING_COREELEC_AMLOGIC_DISABLEGUISCALING = "coreelec.amlogic.disableguiscaling";
static constexpr auto SETTING_COREELEC_AMLOGIC_DV_DISABLE = "coreelec.amlogic.disabledolbyvision";
static constexpr auto SETTING_COREELEC_AMLOGIC_DV_LED = "coreelec.amlogic.dolbyvisionled";
static constexpr auto SETTING_COREELEC_AMLOGIC_DV_STD_SOURCE_LEVELS_METADATA = "coreelec.amlogic.dolbyvision.std.sourcelevelsmetadata";
static constexpr auto SETTING_CACHE_HARDDISK = "cache.harddisk";
static constexpr auto SETTING_CACHEVIDEO_DVDROM = "cachevideo.dvdrom";
static constexpr auto SETTING_CACHEVIDEO_LAN = "cachevideo.lan";
Expand Down