(bugfix) Game.PushNotationMove() fails to push for PGN games#63
Merged
CorentinGS merged 1 commit intoCorentinGS:mainfrom Jul 21, 2025
Merged
Conversation
When a Game is initialized via PGN(), subsequent moves appended to the original via Game.PushNotationMove() are not being appended. (The game's position gets updated, but the move is missing). The root cause is Parser.Parse() fails to initialize Game.currentMove to the last move of the PGN, so Game.addNewMove() was not adding the move as expected. Added a new test to catch this as well as augmented an existing PGN read test.
mikeb26
added a commit
to mikeb26/chesstools
that referenced
this pull request
Jul 24, 2025
This commit updates dependencies to ensure CorentinGS/chess#63 is included. Without this repmk misbehaves and skips positions in its output. Additionally this commit adds additional tests and guards to catch this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Game is initialized via PGN(), subsequent moves appended to the original via Game.PushNotationMove() are not being appended. (The game's position gets updated, but the move is missing). The root cause is Parser.Parse() fails to initialize Game.currentMove to the last move of the PGN, so Game.addNewMove() was not adding the move as expected. Added a new test to catch this as well as augmented an existing PGN read test.