Feature/refactor availability time picker #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Indicator component to fix bug where the spinner was not visible
…kerManager does not conform to RCTModuleProvider error on ios
CharlesBither
commented
Dec 7, 2025
Collaborator
Author
There was a problem hiding this comment.
This file is the patch described in this PR's description.
CharlesBither
requested review from
Elisjoshi,
SpencerJohnson9904,
abalsara and
andrasmarto1
…to feature/refactor-availability-time-picker
SpencerJohnson9904
approved these changes
Dec 8, 2025
Collaborator
SpencerJohnson9904
left a comment
SpencerJohnson9904
left a comment
There was a problem hiding this comment.
LGTM! Got packages setup to pass CI, the new page looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the time picker modal according to the feedback on #78 (comment) .
Below, are the key changes:
The react-native-paper-dates module has been replaced with react-native-date-picker. Instead of a clock modal, a bottom-sheet style modal is now displayed, allowing the user to select a time by using a scroll picker.
react-native-date-picker was chosen instead of more popular libraries such as react-native-community/datetimepicker so that the picker can be displayed inline on android, as opposed to being displayed as a dialog.
The latest version of the library (5.0.13) has compatibility issues with the latest version of RN, causing a "Module provider RNDatePickerManager does not conform to RCTModuleProvider" error on ios as described here. This patch fixes the issue and can be found in our project under /patches. The patch is automatically applied during npm install.
Rather than updating the database whenever an availability is inserted or deleted from the page, these actions are now applied to the page immediately. The database is only updated when the user presses the "Save" button. Additionally, the save button is disabled if no changes have been made to the page.
The DayIcon component is now used instead of the MaterialCommunityIcons to better match the theme of the app.