forked from Phobos-developers/Phobos
-
Notifications
You must be signed in to change notification settings - Fork 0
Warhead cankill 2 #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Coronia
wants to merge
18
commits into
develop
Choose a base branch
from
warhead-cankill-2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Warheads can now damage the enemy without killing them (minimum health will be 1). - Verified in conventional weapons and radiation types. In `rulesmd.ini`: [SOMEWARHEAD] ; Warhead CanKill=false ; boolean
CanKill is by default true
regarding the WH re-declaration warning and the double to int
- I used a wrong function for cheking the damage value xD - Small changes so now it doesn't skip code in ReceiveDamage hook.
…e on uncrushable unit (Phobos-developers#1529) - Fix an issue where a unit will leave an impassable invisible barrier in its original position when it is teleported by ChronoSphere onto an uncrushable unit and self destruct. Thx to @NetsuNegi .
added a few more tags to further customize ReflectDamage - `ReflectDamage.Chance` determines the chance of reflection. - `ReflectDamage.Override` directly overrides the damage. - `SuppressReflectDamage.Groups` does the same thing as `SuppressReflectDamage.Types` but for all AttachEffectTypes in the listed groups. In `rulesmd.ini`: ```ini [SOMEATTACHEFFECT] ; AttachEffectType ReflectDamage.Chance=1.0 ; floating point value ReflectDamage.Override= ; integer [SOMEWARHEAD] SuppressReflectDamage.Groups= ; comma-separated list of strings (group IDs) ```
…` units after it's been damaged by a fallen unit lifted by `IsLocomotor=yes` warheads (Phobos-developers#1629) Fix the bug that a unit can overlap with `Teleport=yes` units after it's been damaged by a fallen unit lifted by `IsLocomotor=yes` warheads
…cankill # Conflicts: # CREDITS.md # YRpp # docs/Fixed-or-Improved-Logics.md # docs/Whats-New.md # src/Ext/Techno/Hooks.ReceiveDamage.cpp # src/Ext/WarheadType/Body.cpp # src/Ext/WarheadType/Body.h # src/Misc/Hooks.BugFixes.cpp
# Conflicts: # src/Ext/RadSite/Body.cpp # src/Ext/Techno/Hooks.ReceiveDamage.cpp
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.