Merged
Conversation
CosmicHorrorDev
force-pushed
the
0.2.x
branch
3 times, most recently
from
6e5f307 to
ac93e17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So there have been breaking changes chilling out in
mainfor a while. Unfortunately these changes have stalled on getting to a point where I'm entirely happy, and I think I'm more comfortable building on a different parser library likewinnow(re #89) over a fully manual implementation1.Instead this brings back the old
pestbased parser that now depends directly onpestinstead of generating the code from the grammar withpest_derivesince I'm happy with that approach for now, and would like to focus on improving the API and deprecating things in prep for the next breaking releaseFootnotes
Specifically getting the errors to the point where they're user-friendly and context-full enough was not looking realistic ↩