fix: Allow multiple tries for PowerBI params update #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N1K1T4
force-pushed
the
NMAU/multiple_tries_for_powerbi_params
branch
from
1e942a2 to
1235959
Compare
N1K1T4
force-pushed
the
NMAU/multiple_tries_for_powerbi_params
branch
from
1235959 to
e6cf3cc
Compare
|
The tests failing does not seems to be related to my modifications but rather to the deletion of the dev platform. |
|
Sometimes the parameters update fails for an unknown reason (it also happens with the manual procedure). A retry fix the issue in most cases. Before: After: |
bmoreau
requested review from
MohcineTor,
edontafiliext and
ggtrd
and removed request for
bmoreau
MohcineTor
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
LGTM 👍
Yes, the platform dev is deprecated. we should adapt the test accordingly. I’ll try to look into it as well. Thanks, @N1K1T4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.