-
Notifications
You must be signed in to change notification settings - Fork 1
allow keycloak groups in RBAC for easier user handling #1074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow keycloak groups in RBAC for easier user handling #1074
Conversation
fc708ef to
49e5821
Compare
7cf161d to
15900c1
Compare
jreynard-code
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remarks but I can't wait to have this in new version ;)
common/src/main/kotlin/com/cosmotech/common/config/CsmPlatformProperties.kt
Outdated
Show resolved
Hide resolved
common/src/main/kotlin/com/cosmotech/common/utils/SecurityUtils.kt
Outdated
Show resolved
Hide resolved
15900c1 to
4194a32
Compare
jreynard-code
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some easy remarks to tackle ;)
...src/integrationTest/kotlin/com/cosmotech/organization/service/OrganizationServiceRBACTest.kt
Outdated
Show resolved
Hide resolved
organization/src/test/kotlin/com/cosmotech/organization/service/OrganizationServiceImplTests.kt
Outdated
Show resolved
Hide resolved
run/src/integrationTest/kotlin/com/cosmotech/run/service/RunServiceIntegrationTest.kt
Outdated
Show resolved
Hide resolved
runner/src/integrationTest/kotlin/com/cosmotech/runner/service/RunnerServiceIntegrationTest.kt
Outdated
Show resolved
Hide resolved
runner/src/integrationTest/kotlin/com/cosmotech/runner/service/RunnerServiceRBACTest.kt
Outdated
Show resolved
Hide resolved
.../src/integrationTest/kotlin/com/cosmotech/solution/service/SolutionServiceIntegrationTest.kt
Outdated
Show resolved
Hide resolved
solution/src/integrationTest/kotlin/com/cosmotech/solution/service/SolutionServiceRBACTest.kt
Outdated
Show resolved
Hide resolved
...rc/integrationTest/kotlin/com/cosmotech/workspace/service/WorkspaceServiceIntegrationTest.kt
Outdated
Show resolved
Hide resolved
...space/src/integrationTest/kotlin/com/cosmotech/workspace/service/WorkspaceServiceRBACTest.kt
Outdated
Show resolved
Hide resolved
workspace/src/test/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImplTests.kt
Outdated
Show resolved
Hide resolved
4194a32 to
dbd8c50
Compare
dbd8c50 to
339021f
Compare
jreynard-code
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.