Increase maxLength for string fields in OpenAPI specs from 50 to 150 across multiple schemas #1083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…across multiple schemas
sjoubert
approved these changes
Nov 3, 2025
Contributor
There was a problem hiding this comment.
Just my personal thoughts here:
- Unless we have a precise technical limit, I would be on the no limit side here. Yes long names are not a good idea, but this is not our role to force good practices on users (most of the time). We can document them, but in the end there will always be a valid reason for wanting LIMIT+1.
- I also believe that, by default, adding "artificial"/unnecessary constraints leads to worse software. These restrictions needs to be specified, documented, tested and often just increase the bug surface area.
Anyway, LGTM :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.