Check if a dataset is attached to a runner on dataset deletion #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced methods to associate dataset parameters with runners (`findRunnerByDatasetParameter`) in `RunnerService`. - Added event `GetAttachedRunnerToDataset` for validating dataset usage during deletion. - Updated documentation and OpenAPI spec with indexed `dataset` field representation. - Implemented new integration tests for dataset usage validation and deletion constraints.
Leopold-Cramer
approved these changes
Nov 6, 2025
common/src/main/kotlin/com/cosmotech/common/events/RunnerEvents.kt
Outdated
Show resolved
Hide resolved
dataset/src/main/kotlin/com/cosmotech/dataset/service/DatasetServiceImpl.kt
Outdated
Show resolved
Hide resolved
runner/src/integrationTest/kotlin/com/cosmotech/runner/service/RunnerServiceIntegrationTest.kt
Outdated
Show resolved
Hide resolved
runner/src/integrationTest/kotlin/com/cosmotech/runner/service/RunnerServiceIntegrationTest.kt
Outdated
Show resolved
Hide resolved
runner/src/main/kotlin/com/cosmotech/runner/service/RunnerApiServiceImpl.kt
Outdated
Show resolved
Hide resolved
- Added `datasetParameterId` field to `RunnerDeleted` event. - Implemented `onRunnerDeleted` listener in `DatasetServiceImpl` to handle cleanup of datasets and parts linked to a runner. - Updated `RunnerService` to trigger `RunnerDeleted` with `datasetParameterId`.
jreynard-code
force-pushed
the
add_check_on_dataset_deletion
branch
from
8abcca1 to
e1083dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findRunnerByDatasetParameter) inRunnerService.GetAttachedRunnerToDatasetfor validating dataset usage during deletion.datasetfield representation.