Handle NoSuchKeyException in exception handling and add related integration tests #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration tests - Added a handler for `NoSuchKeyException` to return a NOT_FOUND response with appropriate details. - Introduced integration tests to validate behavior when accessing non-existent workspace files.
sjoubert
requested changes
Nov 14, 2025
common/src/main/kotlin/com/cosmotech/common/exceptions/CsmExceptionHandling.kt
Outdated
Show resolved
Hide resolved
api/src/integrationTest/kotlin/com/cosmotech/api/home/workspace/WorkspaceControllerTests.kt
Outdated
Show resolved
Hide resolved
- Updated `WorkspaceServiceImpl` to catch `NoSuchKeyException` and throw `CsmResourceNotFoundException` with a customized error message. - Modified related exception handler to return detailed NOT_FOUND response. - Updated integration tests to validate new exception handling and error messages.
jreynard-code
force-pushed
the
fix_error_response_when_download_workspace_file_with_wrong_name_PROD-14965
branch
from
380e66e to
d63f3dc
Compare
jreynard-code
force-pushed
the
fix_error_response_when_download_workspace_file_with_wrong_name_PROD-14965
branch
from
d63f3dc to
c7ca80b
Compare
sjoubert
approved these changes
Nov 20, 2025
jreynard-code
deleted the
fix_error_response_when_download_workspace_file_with_wrong_name_PROD-14965
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoSuchKeyExceptionto return a NOT_FOUND response with appropriate details.