Fix 500 path variables empty prod 14970 #1096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjoubert
approved these changes
Nov 25, 2025
jreynard-code
force-pushed
the
fix_500_path_variables_empty_PROD-14970
branch
2 times, most recently
from
967f483 to
850dbbf
Compare
- Added validation to ensure IDs (e.g., `organizationId`, `workspaceId`, `runnerId`, `datasetId`, etc.) are not blank in service methods. - Updated dataset and organization integration tests to cover scenarios with empty IDs.
…iers - Added `deleteRun`, `getRun`, `getRunLogs`, `getRunStatus`, and `listRuns` integration tests to verify not-blank validation for `organizationId`, `workspaceId`, `runnerId`, and `runId`. - Refactored `RunServiceIntegrationTest` to remove unnecessary mocks and declarations.
…tifiers - Added integration tests for `createRunner`, `deleteRunner`, `getRunner`, `updateRunner`, and other runner-related API methods to verify not-blank validation for `organizationId`, `workspaceId`, and `runnerId`. - Removed unnecessary `@Autowired` annotations for spied services.
…gration tests - Introduced regex validation for identifiers such as `organizationId`, `workspaceId`, `runnerId`, `runId`, `solutionId`, and `datasetId` across services and APIs. - Updated OpenAPI specifications to include regex patterns for identifier validation. - Added integration tests for invalid identifier formats in `organization`, `workspace`, `runner`, `run`, `dataset`, and `solution` APIs.
jreynard-code
force-pushed
the
fix_500_path_variables_empty_PROD-14970
branch
from
850dbbf to
3f91acf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.