restrict the possibility for the role_viewer to see the details of security #821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leopold-Cramer
requested review from
jreynard-code,
lalepee,
neomatamune and
sellisd
Leopold-Cramer
force-pushed
the
LCRA/change_security_visibility_per_role_PROD-14053
branch
from
0d54122 to
c51ee71
Compare
sellisd
reviewed
Nov 22, 2024
...et/src/integrationTest/kotlin/com/cosmotech/dataset/service/DatasetServiceIntegrationTest.kt
Outdated
Show resolved
Hide resolved
Leopold-Cramer
force-pushed
the
LCRA/change_security_visibility_per_role_PROD-14053
branch
2 times, most recently
from
be4716c to
fd058b5
Compare
modified tests in all services after role_viewer got the right to read security
added check in each services for each returned objects containing security if security was returned and the user has the role viewer then only minimal informations on security are returned default security is unchanged, the access control list contains only the user with the role viewer
Leopold-Cramer
force-pushed
the
LCRA/change_security_visibility_per_role_PROD-14053
branch
from
fd058b5 to
fb4b166
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dataset/src/test/kotlin/com/cosmotech/dataset/service/DatasetServiceImplTests.kt
Fixed
Show fixed
Hide fixed
jreynard-code
requested changes
Nov 28, 2024
Member
jreynard-code
left a comment
jreynard-code
left a comment
There was a problem hiding this comment.
A lots of remarks, but don't be afraid, there are a lot of duplication.
Feel free to change one module at a time and I will double check that with you each time.
Good job btw ;)
runner/src/integrationTest/kotlin/com/cosmotech/runner/service/RunnerServiceIntegrationTest.kt
Outdated
Show resolved
Hide resolved
runner/src/integrationTest/kotlin/com/cosmotech/runner/service/RunnerServiceIntegrationTest.kt
Show resolved
Hide resolved
runner/src/integrationTest/kotlin/com/cosmotech/runner/service/RunnerServiceIntegrationTest.kt
Show resolved
Hide resolved
runner/src/main/kotlin/com/cosmotech/runner/service/RunnerApiServiceImpl.kt
Outdated
Show resolved
Hide resolved
runner/src/main/kotlin/com/cosmotech/runner/service/RunnerApiServiceImpl.kt
Outdated
Show resolved
Hide resolved
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Outdated
Show resolved
Hide resolved
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Outdated
Show resolved
Hide resolved
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Outdated
Show resolved
Hide resolved
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Outdated
Show resolved
Hide resolved
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Outdated
Show resolved
Hide resolved
Leopold-Cramer
force-pushed
the
LCRA/change_security_visibility_per_role_PROD-14053
branch
2 times, most recently
from
ee7d78d to
bbc22a4
Compare
Leopold-Cramer
force-pushed
the
LCRA/change_security_visibility_per_role_PROD-14053
branch
from
bbc22a4 to
7e7a2c0
Compare
Leopold-Cramer
changed the title
jreynard-code
requested changes
Dec 10, 2024
Member
jreynard-code
left a comment
jreynard-code
left a comment
There was a problem hiding this comment.
A simple remark that I missed at first sight.
Except that, GG ;)
dataset/src/main/kotlin/com/cosmotech/dataset/service/DatasetServiceImpl.kt
Outdated
Show resolved
Hide resolved
Leopold-Cramer
force-pushed
the
LCRA/change_security_visibility_per_role_PROD-14053
branch
from
7e7a2c0 to
4e34baa
Compare
Leopold-Cramer
deleted the
LCRA/change_security_visibility_per_role_PROD-14053
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restrict the possibility for the role_viewer to see the details of security