Skip to content

fix: check filenames as we do for destination paths #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sellisd merged 1 commit into from
Nov 26, 2024
Merged

fix: check filenames as we do for destination paths #827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,10 @@ internal class WorkspaceServiceImpl(
throw IllegalArgumentException("Invalid destination: '$destination'. '..' is not allowed")
}
val workspace = getVerifiedWorkspace(organizationId, workspaceId, PERMISSION_WRITE)
if (file?.filename?.contains("..") == true || file?.filename?.contains("/") == true) {
Copy link
Contributor

@Leopold-Cramer Leopold-Cramer Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be useful to check for "" too ?

Copy link
Contributor Author

@sellisd sellisd Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quote is a possible character for a filename (even though not very useful), and since it cannot be abused to write to a different location I think we should keep it

throw IllegalArgumentException(
"Invalid filename: '${file.filename}'. '..' and '/' are not allowed")
}

logger.debug(
"Uploading file resource to workspace #{} ({}): {} => {}",
Expand Down
Loading