Skip to content

Conversation

@neomatamune
Copy link
Member

During patch run template id is not ensured to be present in query, so comparing to query value which can be null resulting in no run template to be found. Instead using the existing in store value ensure that we have the run template to look for.

During patch run template id is not ensured to be present in query,
so comparing to query value which can be null resulting in no run template to be found.
Instead using the existing in store value ensure that we have the run template to look for.
@neomatamune neomatamune force-pushed the AFOS/parameter_update_should_not_require_runtemplateid branch from 423fd1c to 0cafa05 Compare November 26, 2024 15:05
Copy link
Member

@jreynard-code jreynard-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreynard-code jreynard-code merged commit abcce8f into release/v3.2 Nov 27, 2024
35 checks passed
@jreynard-code jreynard-code deleted the AFOS/parameter_update_should_not_require_runtemplateid branch November 27, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants