Lcra/refactor workspace openapi prod 14206 #858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leopold-Cramer
force-pushed
the
LCRA/refactor_workspace_openapi1_PROD-14206
branch
3 times, most recently
from
6040e8e to
ebe6471
Compare
sjoubert
requested changes
Jan 28, 2025
jreynard-code
requested changes
Jan 29, 2025
run/src/integrationTest/kotlin/com/cosmotech/run/service/RunServiceIntegrationTest.kt
Show resolved
Hide resolved
...space/src/integrationTest/kotlin/com/cosmotech/workspace/service/WorkspaceServiceRBACTest.kt
Show resolved
Hide resolved
...space/src/integrationTest/kotlin/com/cosmotech/workspace/service/WorkspaceServiceRBACTest.kt
Show resolved
Hide resolved
...space/src/integrationTest/kotlin/com/cosmotech/workspace/service/WorkspaceServiceRBACTest.kt
Show resolved
Hide resolved
...space/src/integrationTest/kotlin/com/cosmotech/workspace/service/WorkspaceServiceRBACTest.kt
Show resolved
Hide resolved
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Outdated
Show resolved
Hide resolved
jreynard-code
requested changes
Jan 29, 2025
Member
jreynard-code
left a comment
jreynard-code
left a comment
There was a problem hiding this comment.
Some buggy changes.
Go deeper in changes please and add some tests to be sure that it works as it should ;)
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Show resolved
Hide resolved
Leopold-Cramer
force-pushed
the
LCRA/refactor_workspace_openapi1_PROD-14206
branch
from
d09e282 to
a9a3700
Compare
jreynard-code
requested changes
Feb 5, 2025
Member
jreynard-code
left a comment
jreynard-code
left a comment
There was a problem hiding this comment.
Some work to do but the end is close! Be strong ;)
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Show resolved
Hide resolved
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Show resolved
Hide resolved
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Show resolved
Hide resolved
...rc/integrationTest/kotlin/com/cosmotech/workspace/service/WorkspaceServiceIntegrationTest.kt
Show resolved
Hide resolved
Leopold-Cramer
force-pushed
the
LCRA/refactor_workspace_openapi1_PROD-14206
branch
from
a9a3700 to
b50f34e
Compare
jreynard-code
requested changes
Feb 12, 2025
Member
jreynard-code
left a comment
jreynard-code
left a comment
There was a problem hiding this comment.
Some remarks.
Almost there ;)
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Outdated
Show resolved
Hide resolved
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Outdated
Show resolved
Hide resolved
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Outdated
Show resolved
Hide resolved
Leopold-Cramer
force-pushed
the
LCRA/refactor_workspace_openapi1_PROD-14206
branch
2 times, most recently
from
4eeee5c to
16b2fc2
Compare
sjoubert
approved these changes
Feb 18, 2025
…tions in all service
…+ modified examples
Leopold-Cramer
force-pushed
the
LCRA/refactor_workspace_openapi1_PROD-14206
branch
from
cb3c768 to
9a34070
Compare
Leopold-Cramer
force-pushed
the
LCRA/refactor_workspace_openapi1_PROD-14206
branch
from
9a34070 to
741cad9
Compare
Leopold-Cramer
changed the title
Leopold-Cramer
deleted the
LCRA/refactor_workspace_openapi1_PROD-14206
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.