fix: repair generated python client code #859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The openapi-generator-gradle-plugin depends has a transitive dependency on com.samskivert:jmustache:1.15, however the .owasp.dependencycheck.gradle.plugin depends on the more recent 1.16 version so when both plugins are included the generated python code has syntax errors (see bug issue: OpenAPITools/openapi-generator#20375) To avoid this conflict of plugin dependencies we have to force the resolution of dependencies to keep the old version.
sjoubert
requested changes
Jan 30, 2025
sjoubert
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The openapi-generator-gradle-plugin depends has a transitive dependency on com.samskivert:jmustache:1.15, however the .owasp.dependencycheck.gradle.plugin depends on the more recent 1.16 version so when
both plugins are included the generated python code has syntax errors (see bug issue: OpenAPITools/openapi-generator#20375) To avoid this conflict of plugin dependencies we have to force the resolution of dependencies to
keep the old version. Forcing the dependency also introduces some changes in the typescript client, but fortunately these are new lines that do not seem to have an effect