Skip to content

Conversation

csm-thu
Copy link
Member

@csm-thu csm-thu commented Jan 21, 2025

No description provided.

…n fail

BREAKING CHANGE: the function isValid now returns an Error object when
the validation failed, or true if it succeeded. The Error object
contains three fields: summary, context and location (the last one is
set to null by the isValid function).
@csm-thu csm-thu requested review from esasova and nborde-CSM January 21, 2025 15:29
Copy link
Contributor

@esasova esasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@csm-thu csm-thu force-pushed the THU/range_validation_on_table_upload branch 2 times, most recently from 5064dfc to f4327de Compare January 22, 2025 10:18
@csm-thu csm-thu requested a review from esasova January 22, 2025 10:20
Copy link
Contributor

@esasova esasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@nborde-CSM nborde-CSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

…e uploads

ValidationUtils.isValid, AgGridUtils.fromCSV and AgGridUtils.fromXLSX
functions will now validate input data against minValue and maxValue
options (if provided).
@csm-thu csm-thu force-pushed the THU/range_validation_on_table_upload branch from f4327de to c7f0b3d Compare January 22, 2025 10:58
@csm-thu csm-thu merged commit 4d0f1df into main Jan 22, 2025
2 checks passed
@csm-thu csm-thu deleted the THU/range_validation_on_table_upload branch January 22, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants