Esas/migrate to react 18 prod 13948 #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csm-thu
reviewed
Oct 18, 2024
| try { | ||
| content = ( | ||
| <PowerBIEmbed cssClassName={classes.report} embedConfig={embedConfig} getEmbeddedComponent={setReport} /> | ||
| <PowerBIEmbed cssClassName={classes.report} embedConfig={embedConfig} getEmbeddedComponent={() => setReport} /> |
There was a problem hiding this comment.
I think this change will break our usage of the getEmbeddedComponent prop. The previous version
getEmbeddedComponent={setReport}
was equivalent to
getEmbeddedComponent={(embedObject) => setReport(embedObject)}
it had the expected function signature (embeddedComponent: Embed): void
Yet the signature of the new version is quite different: () => func
There was a problem hiding this comment.
oh, thank you for the remark, I didn't think about it. Now, we can rollback this change as it was necessary to avoid the app crash because of <StrictMode/> that we decided to disable 😉
esasova
force-pushed
the
ESAS/migrate_to_react_18_PROD_13948
branch
from
d9badfa to
f1341bc
Compare
nborde-CSM
approved these changes
Oct 23, 2024
| export const RolesAddingDialog = ({ | ||
| selectedAgent, | ||
| labels, | ||
| labels: tmpLabels, |
There was a problem hiding this comment.
I think it is possible do it like this :
labels: tmpLabels = DEFAULT_LABELS,
esasova
force-pushed
the
ESAS/migrate_to_react_18_PROD_13948
branch
from
a8510a1 to
8d24b6c
Compare
esasova
changed the base branch from
main
to
experimental/upgrade_all_dependencies
esasova
force-pushed
the
ESAS/migrate_to_react_18_PROD_13948
branch
2 times, most recently
from
ff43be8 to
d1bcdbc
Compare
When the prop visibleScenarios is not provided, the component could raise an error because it tries to access .length of the visibleScenarios array when building the ScenarioDTO for dynamic filters
esasova
force-pushed
the
ESAS/migrate_to_react_18_PROD_13948
branch
from
d1bcdbc to
03fc2a1
Compare
esasova
force-pushed
the
ESAS/migrate_to_react_18_PROD_13948
branch
from
03fc2a1 to
e2f1163
Compare
esasova
merged commit 21cdc40
into
experimental/upgrade_all_dependencies
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.