Skip to content

fix: auto focus on sign in button #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

fix: auto focus on sign in button #430

merged 1 commit into from
Jul 17, 2025

Conversation

arianber7
Copy link
Contributor

No description provided.

@arianber7 arianber7 requested review from csm-thu and nborde-CSM July 16, 2025 08:30
@arianber7 arianber7 self-assigned this Jul 16, 2025
csm-thu
csm-thu approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@csm-thu csm-thu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit prefix should be changed from "feat" to "fix", but for the code, it looks good to me 👍

@arianber7 arianber7 force-pushed the ABE/auto_focus_on_signin_button-PROD-8136 branch from f272701 to 84d6725 Compare July 16, 2025 09:56
@arianber7 arianber7 changed the title feat: auto focus on sign in button fix: auto focus on sign in button Jul 16, 2025
nborde-CSM
nborde-CSM approved these changes Jul 16, 2025
View reviewed changes
Copy link
Collaborator

@nborde-CSM nborde-CSM left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add the ticket id on your commit description like this :
fix: [PROD-XXXX] foo foo foo

Otherwise, LGTM 👍

@arianber7 arianber7 force-pushed the ABE/auto_focus_on_signin_button-PROD-8136 branch 3 times, most recently from 9d8309e to 84d6725 Compare July 17, 2025 11:14
@arianber7 arianber7 merged commit 874be37 into main Jul 17, 2025
8 checks passed
@arianber7 arianber7 deleted the ABE/auto_focus_on_signin_button-PROD-8136 branch July 17, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nborde-CSM nborde-CSM nborde-CSM approved these changes

@csm-thu csm-thu csm-thu approved these changes

Assignees

@arianber7 arianber7

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arianber7 @nborde-CSM @csm-thu