Gitignore on Windows problem with mixed slashes.#64
Conversation
# Conflicts: # src/MagentoHackathon/Composer/Magento/GitIgnore.php
…the paths contain mixed slashes.
|
Hi @amsys have you tested on the most recent version? This may have been fixed recently. If not it's certainly fixed in my open PR for Windows test support, however that won't be merged for a while so if it's not fixed in the latest i'm +1 for this patch. It does require a unit test though please. Ideally thid should be fixed higher in the stack but I'm working on that atm. |
|
Hi @AydinHassan, I vote for this change as there is real problem with mixed slashes on Windows machines. Thanks. |
|
@martinpolivkasummit I have no problem with this fix, but it requires a unit-test first. Currently the tests setup for this project is broken so I can't continue the Windows fixes. |
|
@amsys Could you try the master branch when you get some time? this should be fixed now. |
|
sadly our resources(people) were not able to fix the windows tests yet... therefore we are not able to validate if it properly works or breaks something :/ |
Not sure if this is the right way to do it, but my .gitignore with recent release and past releases always contained mixed slashes... for example:
/app/code/local/Aschroder/SMTPPro/Block\Log.php
/app/code/local/Aschroder/SMTPPro/controllers\Smtp\LogController.php