Public trips - Rename fields in host request by nabramow · Pull Request #7740 · Couchers-org/couchers

nabramow · 2026-01-25T04:40:59Z

Describe briefly what this PR is doing and why.

To prepare for public trips, we will first rename surfer_user_id and host_user_id to recipient and initiator. This is because public trips will allow us going both directions so the surfer initiates normally but host initiates with public trips.

Testing

Explain how you tested this PR and give clear steps so the reviewer can replicate.

Upgrade and downgrade migrations should work
Send a couple host requests and go through reference flow. Should still work exactly as before.

Backend checklist

Added tests for any new code or added a regression test if fixing a bug
Run the backend locally and it works
Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

For maintainers

Maintainers can push commits to my branch
Maintainers can merge this PR for me

vercel · 2026-01-25T04:41:04Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
couchers	Ready	Preview	Feb 22, 2026 3:58pm

couchersbot · 2026-02-22T04:07:47Z

Claude finished @nabramow's task in 2m 3s —— View job

Migration Safety Review Complete

Get PR diff and identify migration files
Read migration file(s) in full
Check current production schema
Review model changes
Evaluate against safety checklist
Post review summary

Result: SAFE - The migration 0140_rename_host_request_user_columns_v2.py performs metadata-only column, index, and constraint renames on host_requests. No data modification, no type changes, no new constraints. Full details in the migration review comment.

couchersbot · 2026-02-22T04:09:55Z

Migration Review

One of our most common issues is migrations that don't work with existing data in production. This is very hard to catch with CI, so we have this bot to check for potential problems.

Overall Risk: SAFE

Files Reviewed

0140_rename_host_request_user_columns_v2.py - Renames 11 columns, 4 indexes, and 2 FK constraints on host_requests table from surfer/host naming to initiator/recipient naming.

Findings

No issues found. Column renames (ALTER COLUMN ... RENAME TO), index renames (ALTER INDEX ... RENAME TO), and constraint renames are all metadata-only operations in PostgreSQL - they do not rewrite the table or affect existing data. Dependent objects (materialized views like user_response_rates, other indexes) reference columns by internal attribute number (attnum), so they continue to work after renames.

The defensive inspect() checks for column/index existence before renaming add robustness (useful since this is "v2" of the migration).

Note: The downgrade raises NotImplementedError. This is acceptable for a rename migration but means rollback requires a new forward migration.

Summary

This is a safe, metadata-only migration. All 11 column renames, 4 index renames, and 2 FK constraint renames are correctly mapped and match the model changes in host_requests.py. No data modification, no type changes, no constraint additions - just naming updates.

couchersbot · 2026-02-22T15:55:35Z

Claude finished @nabramow's task in 1m 49s —— View job

Migration Safety Review Complete

Get PR diff and identify migration files
Read migration file(s) in full
Check current production schema
Review model changes
Evaluate against safety checklist
Post review summary

Result: SAFE - The migration 0140_rename_host_request_user_columns_v2.py performs metadata-only column, index, and constraint renames on host_requests. No data modification, no type changes, no new constraints. Full details in the migration review comment.

aapeliv

some comments. let's just change the column names in the host request table in this PR

aapeliv · 2026-02-22T15:55:57Z

app/backend/src/couchers/migrations/versions/0140_rename_host_request_user_columns_v2.py

+    conn = op.get_bind()
+    inspector = inspect(conn)
+    columns = {col["name"] for col in inspector.get_columns("host_requests")}
+    indexes = {idx["name"] for idx in inspector.get_indexes("host_requests")}
+
+    # Helper to rename column only if old name exists
+    def rename_column(old_name, new_name):
+        if old_name in columns:
+            op.alter_column("host_requests", old_name, new_column_name=new_name)
+
+    # Helper to rename index only if old name exists
+    def rename_index(old_name, new_name):
+        if old_name in indexes:
+            op.execute(f"ALTER INDEX {old_name} RENAME TO {new_name}")


Let's not do this; just normal renaming per-column please

aapeliv · 2026-02-22T15:57:24Z

app/backend/src/tests/test_moderation.py



-def create_test_host_request_with_moderation(surfer_token, host_user_id):
+def create_test_host_request_with_moderation(surfer_token, recipient_user_id):


let's not change this one

aapeliv · 2026-02-22T15:57:39Z

app/backend/src/tests/test_references.py

+    initiator_user_id: int,
+    recipient_user_id: int,


here to keep as is

aapeliv · 2026-02-22T15:58:34Z

app/proto/requests.proto

 }

 message CreateHostRequestReq {
-  int64 host_user_id = 1;


The API surface shouldn't change

Rename fields

f3b9019

vercel bot deployed to Preview January 25, 2026 04:41 View deployment

Forgot to save these

d11d8c4

vercel bot had a problem deploying to Preview January 25, 2026 13:10 Failure

nabramow mentioned this pull request Feb 16, 2026

Backend: Add public_trips models and migration #7723

Merged

7 tasks

Update frontend keys

ebe3138

nabramow marked this pull request as ready for review February 22, 2026 04:07

nabramow requested a review from aapeliv as a code owner February 22, 2026 04:07

vercel bot deployed to Preview February 22, 2026 04:13 View deployment

nabramow changed the title ~~WIP DRAFT - Rename fields in host request~~ Public trips - Rename fields in host request Feb 22, 2026

Merge branch 'develop' into na/backend/naming-host-req

a067b1f

vercel bot deployed to Preview February 22, 2026 15:58 View deployment

aapeliv requested changes Feb 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Public trips - Rename fields in host request#7740

Public trips - Rename fields in host request#7740
nabramow wants to merge 4 commits intodevelopfrom
na/backend/naming-host-req

nabramow commented Jan 25, 2026

Uh oh!

vercel bot commented Jan 25, 2026 •

edited

Loading

Uh oh!

couchersbot bot commented Feb 22, 2026 •

edited

Loading

Uh oh!

couchersbot bot commented Feb 22, 2026 •

edited

Loading

Uh oh!

couchersbot bot commented Feb 22, 2026 •

edited

Loading

Uh oh!

aapeliv left a comment

Uh oh!

aapeliv Feb 22, 2026

Uh oh!

aapeliv Feb 22, 2026

Uh oh!

aapeliv Feb 22, 2026

Uh oh!

aapeliv Feb 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants



		def create_test_host_request_with_moderation(surfer_token, host_user_id):
		def create_test_host_request_with_moderation(surfer_token, recipient_user_id):

Comments

Conversation

nabramow commented Jan 25, 2026

Testing

For maintainers

Uh oh!

vercel bot commented Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

couchersbot bot commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Migration Safety Review Complete

Uh oh!

couchersbot bot commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Migration Review

Files Reviewed

Findings

Summary

Uh oh!

couchersbot bot commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Migration Safety Review Complete

Uh oh!

aapeliv left a comment

Choose a reason for hiding this comment

Uh oh!

aapeliv Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

aapeliv Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

aapeliv Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

aapeliv Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Jan 25, 2026 •

edited

Loading

couchersbot bot commented Feb 22, 2026 •

edited

Loading

couchersbot bot commented Feb 22, 2026 •

edited

Loading

couchersbot bot commented Feb 22, 2026 •

edited

Loading