Frontend/profile: Switch pronouns to text input for i18n#7849
Frontend/profile: Switch pronouns to text input for i18n#7849tristanlabelle wants to merge 2 commits intodevelopfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
aapeliv
left a comment
There was a problem hiding this comment.
I agree that the current setup is silly as it's untraslateable. As discussed it's tricky.
What I'm worried about now is that frankly I think there's a lot of people who don't really know what "pronouns" are: if it has some default options, then at least lots of (English pseaking) users will kind of know what it's about. Combined with the i18n woes, I would frankly try to come up with some way to de-emphasize this in the UI.
I also think it would make more sense to have this input be next to the name.
I think my recommendation for now would be to move this next to the name field and maybe mark it as "(optional)" or put in some example "e.g. she/her" or similar, so it's not confusing to someone who has little clue what this is about?
|
@aapeliv Totally agree with your take. I think custom pronouns are quite a US-centric (maybe English-centric) issue, and honestly not really my battle if I have to choose between it and internationalization. I'll give a try at de-emphasizing and adding an example (both good ideas), and we'll see what it looks like. |
Fixes #7438, see that bug for why a radio button is problematic for internationalization.
Testing
Web frontend checklist
For maintainers