Skip to content

Fix missing translation errors from ImageInput#7954

Merged
nabramow merged 4 commits intodevelopfrom
na/web/image-input-translations
Feb 24, 2026
Merged

Fix missing translation errors from ImageInput#7954
nabramow merged 4 commits intodevelopfrom
na/web/image-input-translations

Conversation

@nabramow
Copy link
Member

Fixing the missing translation string errors for ImageInput. This was happening as ImageInput was importing from the PROFILE namespace but it's also uses on EditEventPage which is in the COMMUNITIES namespace.

I moved the translations into GLOBAL since this component is reused in a few places.

@vercel
Copy link

vercel bot commented Feb 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
couchers Ready Ready Preview Feb 24, 2026 10:00am

Request Review

aapeliv
aapeliv previously approved these changes Feb 22, 2026
@aapeliv
Copy link
Member

aapeliv commented Feb 22, 2026

actually maybe wait for @tristanlabelle to comment

tristanlabelle
tristanlabelle previously approved these changes Feb 22, 2026
Copy link
Contributor

@tristanlabelle tristanlabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is fine but I'm a little concerned we have a wider transitivity problem where some piece of code needs to know the set of all string namespaces that will be read.

Comment on lines +44 to +46
"select_an_image": "Select an image",
"click_replace_image": "Click to replace image",
"couldnt_read_file": "Couldn't read file",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're forcing relocalization anyways, we can take advantage to improve the keys (scope within context + specify the type)

  "image_input": {
    "a11y": "Select an image",
    "tooltip": "Click to replace image",
    "read_file_error": "Couldn't read file"
  },

tristanlabelle
tristanlabelle previously approved these changes Feb 23, 2026
@nabramow
Copy link
Member Author

Fix is fine but I'm a little concerned we have a wider transitivity problem where some piece of code needs to know the set of all string namespaces that will be read.

Yeah we have an issue with the GLOBAL namespace being massive and too much in there for this reasson, but it's not a quick thing to solve so 🤷‍♀️. We need generally to do an audit of the translation files. Move things out of global that don't need to be there etc. etc.

@nabramow nabramow merged commit 80b3106 into develop Feb 24, 2026
7 checks passed
@nabramow nabramow deleted the na/web/image-input-translations branch February 24, 2026 17:21
@github-actions
Copy link
Contributor

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This PR fixes translation errors in the ImageInput component by moving translation strings to the GLOBAL namespace. This is an internal code organization fix that resolves console errors developers were seeing, but doesn't change any user-facing functionality or fix any bug that users would have noticed. The component works the same way for end users before and after this change.

🤖 Bot Debug Information

Model: anthropic.claude-4.5-sonnet
Decision: exclude
Reasoning: This PR fixes translation errors in the ImageInput component by moving translation strings to the GLOBAL namespace. This is an internal code organization fix that resolves console errors developers were seeing, but doesn't change any user-facing functionality or fix any bug that users would have noticed. The component works the same way for end users before and after this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants