Skip to content

Commit 1a7d8fa

Browse files
fix: codacy
1 parent e627552 commit 1a7d8fa

File tree

2 files changed

+10
-12
lines changed

2 files changed

+10
-12
lines changed

sdk/src/androidTest/java/ly/count/android/sdk/UtilsInternalLimitsTests.java

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
import org.junit.runner.RunWith;
1313
import org.mockito.Mockito;
1414

15-
import static org.mockito.Mockito.mock;
16-
1715
@RunWith(AndroidJUnit4.class)
1816
public class UtilsInternalLimitsTests {
1917

@@ -160,7 +158,7 @@ public void truncateSegmentationKeys_inconsistentKeys() {
160158
*/
161159
@Test(expected = AssertionError.class)
162160
public void truncateSegmentationValues_null() {
163-
UtilsInternalLimits.truncateSegmentationValues(null, 10, "someTag", mock(ModuleLog.class));
161+
UtilsInternalLimits.truncateSegmentationValues(null, 10, "someTag", Mockito.mock(ModuleLog.class));
164162
Assert.assertTrue(true);
165163
}
166164

@@ -170,7 +168,7 @@ public void truncateSegmentationValues_null() {
170168
@Test
171169
public void truncateSegmentationValues_empty() {
172170
Map<String, Object> values = new HashMap<>();
173-
UtilsInternalLimits.truncateSegmentationValues(values, 10, "someTag", mock(ModuleLog.class));
171+
UtilsInternalLimits.truncateSegmentationValues(values, 10, "someTag", Mockito.mock(ModuleLog.class));
174172
Assert.assertTrue(true);
175173
}
176174

@@ -184,7 +182,7 @@ public void truncateSegmentationValues_underLimit() {
184182
values.put("a2", "2");
185183
values.put("a3", "3");
186184
values.put("a4", "4");
187-
UtilsInternalLimits.truncateSegmentationValues(values, 6, "someTag", mock(ModuleLog.class));
185+
UtilsInternalLimits.truncateSegmentationValues(values, 6, "someTag", Mockito.mock(ModuleLog.class));
188186

189187
Assert.assertEquals(4, values.size());
190188
Assert.assertEquals("1", values.get("a1"));
@@ -203,7 +201,7 @@ public void truncateSegmentationValues_aboveLimit() {
203201
values.put("a2", "2");
204202
values.put("a3", "3");
205203
values.put("a4", "4");
206-
UtilsInternalLimits.truncateSegmentationValues(values, 2, "someTag", mock(ModuleLog.class));
204+
UtilsInternalLimits.truncateSegmentationValues(values, 2, "someTag", Mockito.mock(ModuleLog.class));
207205

208206
Assert.assertEquals(2, values.size());
209207
//after inspecting what is returned in the debugger, it should have the values of "a2" and "a4"
@@ -215,28 +213,28 @@ public void truncateSegmentationValues_aboveLimit() {
215213
public void removeReservedKeysFromSegmentation() {
216214
Map<String, Object> values = new HashMap<>();
217215

218-
UtilsInternalLimits.removeReservedKeysFromSegmentation(values, new String[] {}, "", mock(ModuleLog.class));
216+
UtilsInternalLimits.removeReservedKeysFromSegmentation(values, new String[] {}, "", Mockito.mock(ModuleLog.class));
219217
Assert.assertEquals(0, values.size());
220218

221-
UtilsInternalLimits.removeReservedKeysFromSegmentation(values, new String[] { "a", "", null }, "", mock(ModuleLog.class));
219+
UtilsInternalLimits.removeReservedKeysFromSegmentation(values, new String[] { "a", "", null }, "", Mockito.mock(ModuleLog.class));
222220
Assert.assertEquals(0, values.size());
223221

224222
values.put("b", 1);
225223
Assert.assertEquals(1, values.size());
226-
UtilsInternalLimits.removeReservedKeysFromSegmentation(values, new String[] { "a", "a1", "", null }, "", mock(ModuleLog.class));
224+
UtilsInternalLimits.removeReservedKeysFromSegmentation(values, new String[] { "a", "a1", "", null }, "", Mockito.mock(ModuleLog.class));
227225
Assert.assertEquals(1, values.size());
228226
Assert.assertTrue(values.containsKey("b"));
229227

230228
values.put("a", 2);
231229
Assert.assertEquals(2, values.size());
232-
UtilsInternalLimits.removeReservedKeysFromSegmentation(values, new String[] { "a", "a1", "", null }, "", mock(ModuleLog.class));
230+
UtilsInternalLimits.removeReservedKeysFromSegmentation(values, new String[] { "a", "a1", "", null }, "", Mockito.mock(ModuleLog.class));
233231
Assert.assertEquals(1, values.size());
234232
Assert.assertTrue(values.containsKey("b"));
235233

236234
values.put("a", 2);
237235
values.put("c", 3);
238236
Assert.assertEquals(3, values.size());
239-
UtilsInternalLimits.removeReservedKeysFromSegmentation(values, new String[] { "a", "a1", "", null }, "", mock(ModuleLog.class));
237+
UtilsInternalLimits.removeReservedKeysFromSegmentation(values, new String[] { "a", "a1", "", null }, "", Mockito.mock(ModuleLog.class));
240238
Assert.assertEquals(2, values.size());
241239
Assert.assertTrue(values.containsKey("b"));
242240
Assert.assertTrue(values.containsKey("c"));

sdk/src/main/java/ly/count/android/sdk/UtilsInternalLimits.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ static boolean removeUnsupportedDataTypes(@NonNull Map<String, Object> data, @No
305305
if (key == null || key.isEmpty() || !(isSupportedDataType(value))) {
306306
//found unsupported data type or null key or value, removing
307307
it.remove();
308-
removedKeys.append("key:[").append(key).append("] value:[").append(value).append("] ").append("type: [").append(value == null ? "null" : value.getClass().getSimpleName()).append("] ,");
308+
removedKeys.append("key:[").append(key).append("] value:[").append(value).append("] type:[").append(value == null ? "null" : value.getClass().getSimpleName()).append("] ,");
309309
}
310310
}
311311
String removedKeysStr = removedKeys.toString();

0 commit comments

Comments
 (0)