Skip to content

fix: 28,29 notched phones #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turtledreams merged 1 commit into from
Sep 19, 2025

fix: 28,29 nothed phones

c388889
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix: 28,29 notched phones #498

fix: 28,29 nothed phones
c388889
Select commit
Loading
Failed to load commit list.
GitHub Actions / Unit Test Results :rocket: failed Sep 18, 2025 in 0s

7 fail, 690 pass in 3m 37s

697 tests   690 ✅  3m 37s ⏱️
  1 suites    0 💤
  1 files      7 ❌

Results for commit c388889.

Annotations

Check warning on line 0 in ly.count.android.sdk.DeviceInfoTests

See this annotation in the file changed.

@github-actions github-actions / Unit Test Results :rocket:

testGetResolution (ly.count.android.sdk.DeviceInfoTests) failed 

sdk/build/outputs/androidTest-results/connected/debug/TEST-Android SDK built for x86_64 - 9-_sdk-.xml [took 0s]
Raw output 
org.junit.ComparisonFailure: expected:<1080x1[788]> but was:<1080x1[920]>
at org.junit.Assert.assertEquals(Assert.java:117)
at org.junit.Assert.assertEquals(Assert.java:146)
at ly.count.android.sdk.DeviceInfoTests.testGetResolution(DeviceInfoTests.java:79)

Check warning on line 0 in ly.count.android.sdk.ModuleConfigurationTests

See this annotation in the file changed.

@github-actions github-actions / Unit Test Results :rocket:

viewTrackingDisabled_allFeatures (ly.count.android.sdk.ModuleConfigurationTests) failed 

sdk/build/outputs/androidTest-results/connected/debug/TEST-Android SDK built for x86_64 - 9-_sdk-.xml [took 1s]
Raw output 
java.lang.AssertionError: expected:<2> but was:<1>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:633)
at ly.count.android.sdk.ModuleConfigurationTests.validateCounts(ModuleConfigurationTests.java:1185)
at ly.count.android.sdk.ModuleConfigurationTests.viewTrackingDisabled_allFeatures(ModuleConfigurationTests.java:360)

Check warning on line 0 in ly.count.android.sdk.ModuleConfigurationTests

See this annotation in the file changed.

@github-actions github-actions / Unit Test Results :rocket:

sessionsDisabled_allFeatures (ly.count.android.sdk.ModuleConfigurationTests) failed 

sdk/build/outputs/androidTest-results/connected/debug/TEST-Android SDK built for x86_64 - 9-_sdk-.xml [took 1s]
Raw output 
java.lang.AssertionError: expected:<2> but was:<1>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:633)
at ly.count.android.sdk.ModuleConfigurationTests.validateCounts(ModuleConfigurationTests.java:1185)
at ly.count.android.sdk.ModuleConfigurationTests.sessionsDisabled_allFeatures(ModuleConfigurationTests.java:270)

Check warning on line 0 in ly.count.android.sdk.scSE_SessionsTests

See this annotation in the file changed.

@github-actions github-actions / Unit Test Results :rocket:

SE_206_CR_CNG_A_id_change (ly.count.android.sdk.scSE_SessionsTests) failed 

sdk/build/outputs/androidTest-results/connected/debug/TEST-Android SDK built for x86_64 - 9-_sdk-.xml [took 7s]
Raw output 
java.lang.AssertionError: expected:<5> but was:<6>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:633)
at ly.count.android.sdk.scSE_SessionsTests.SE_206_CR_CNG_A_id_change(scSE_SessionsTests.java:315)

Check warning on line 0 in ly.count.android.sdk.scSE_SessionsTests

See this annotation in the file changed.

@github-actions github-actions / Unit Test Results :rocket:

SE_200_CR_CG_M (ly.count.android.sdk.scSE_SessionsTests) failed 

sdk/build/outputs/androidTest-results/connected/debug/TEST-Android SDK built for x86_64 - 9-_sdk-.xml [took 10s]
Raw output 
java.lang.AssertionError: expected:<6> but was:<7>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:633)
at ly.count.android.sdk.scSE_SessionsTests.SE_200_CR_CG_M(scSE_SessionsTests.java:74)

Check warning on line 0 in ly.count.android.sdk.scSE_SessionsTests

See this annotation in the file changed.

@github-actions github-actions / Unit Test Results :rocket:

SE_201_CNR_M (ly.count.android.sdk.scSE_SessionsTests) failed 

sdk/build/outputs/androidTest-results/connected/debug/TEST-Android SDK built for x86_64 - 9-_sdk-.xml [took 10s]
Raw output 
java.lang.AssertionError: expected:<4> but was:<5>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:633)
at ly.count.android.sdk.scSE_SessionsTests.SE_201_CNR_M(scSE_SessionsTests.java:101)

Check warning on line 0 in ly.count.android.sdk.scUP_UserProfileTests

See this annotation in the file changed.

@github-actions github-actions / Unit Test Results :rocket:

eventSaveScenario_onTimer (ly.count.android.sdk.scUP_UserProfileTests) failed 

sdk/build/outputs/androidTest-results/connected/debug/TEST-Android SDK built for x86_64 - 9-_sdk-.xml [took 3s]
Raw output 
java.lang.AssertionError: expected:<3> but was:<4>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:633)
at ly.count.android.sdk.ModuleUserProfileTests.validateUserProfileRequest(ModuleUserProfileTests.java:897)
at ly.count.android.sdk.ModuleUserProfileTests.validateUserProfileRequest(ModuleUserProfileTests.java:918)
at ly.count.android.sdk.scUP_UserProfileTests.eventSaveScenario_onTimer(scUP_UserProfileTests.java:91)
View more details on GitHub Actions