Skip to content

refactor: remove unnecessary preflight check #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arifBurakDemiray merged 1 commit into from
Nov 13, 2025

refactor: remove unnecessary preflight check

036423a
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

refactor: remove unnecessary preflight check #518

refactor: remove unnecessary preflight check
036423a
Select commit
Loading
Failed to load commit list.
GitHub Actions / Unit Test Results :rocket: failed Nov 11, 2025 in 0s

3 fail, 700 pass in 3m 37s

703 tests   700 ✅  3m 37s ⏱️
  1 suites    0 💤
  1 files      3 ❌

Results for commit 036423a.

Annotations

Check warning on line 0 in ly.count.android.sdk.ModuleViewsTests

See this annotation in the file changed.

@github-actions github-actions / Unit Test Results :rocket:

startView_restartAfterActivityComesFromForeground (ly.count.android.sdk.ModuleViewsTests) failed 

sdk/build/outputs/androidTest-results/connected/debug/TEST-Android SDK built for x86_64 - 9-_sdk-.xml [took 0s]
Raw output 
java.lang.AssertionError: expected:<1.0> but was:<2.0>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:555)
at org.junit.Assert.assertEquals(Assert.java:685)
at ly.count.android.sdk.ModuleEventsTests.validateEvent(ModuleEventsTests.java:1038)
at ly.count.android.sdk.ModuleEventsTests.validateEventInRQ(ModuleEventsTests.java:1014)
at ly.count.android.sdk.ModuleViewsTests.validateView(ModuleViewsTests.java:2085)
at ly.count.android.sdk.ModuleViewsTests.validateView(ModuleViewsTests.java:2066)
at ly.count.android.sdk.ModuleViewsTests.startView_restartAfterActivityComesFromForeground(ModuleViewsTests.java:1814)

Check warning on line 0 in ly.count.android.sdk.scSE_SessionsTests

See this annotation in the file changed.

@github-actions github-actions / Unit Test Results :rocket:

SE_204_CNR_A_id_change (ly.count.android.sdk.scSE_SessionsTests) failed 

sdk/build/outputs/androidTest-results/connected/debug/TEST-Android SDK built for x86_64 - 9-_sdk-.xml [took 7s]
Raw output 
org.junit.ComparisonFailure: expected:<[newID]> but was:<[1234]>
at org.junit.Assert.assertEquals(Assert.java:117)
at org.junit.Assert.assertEquals(Assert.java:146)
at ly.count.android.sdk.TestUtils.validateRequiredParams(TestUtils.java:596)
at ly.count.android.sdk.scSE_SessionsTests.validateSessionUpdateRequest(scSE_SessionsTests.java:386)
at ly.count.android.sdk.scSE_SessionsTests.validateSessionEndRequest(scSE_SessionsTests.java:379)
at ly.count.android.sdk.scSE_SessionsTests.SE_204_CNR_A_id_change(scSE_SessionsTests.java:228)

Check warning on line 0 in ly.count.android.sdk.scSE_SessionsTests

See this annotation in the file changed.

@github-actions github-actions / Unit Test Results :rocket:

SE_201_CNR_M (ly.count.android.sdk.scSE_SessionsTests) failed 

sdk/build/outputs/androidTest-results/connected/debug/TEST-Android SDK built for x86_64 - 9-_sdk-.xml [took 9s]
Raw output 
java.lang.AssertionError: expected:<4> but was:<6>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:633)
at ly.count.android.sdk.scSE_SessionsTests.SE_201_CNR_M(scSE_SessionsTests.java:101)
View more details on GitHub Actions