Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements comprehensive SDK Behavior Settings (SBS) functionality and testing infrastructure for the Countly Flutter SDK. The changes focus on improving the server configuration handling, merging behavior settings, and adding extensive test coverage for various SBS scenarios.
Key changes include:
- Enhanced server configuration merging and storage mechanisms
- Improved behavior settings validation and error handling
- Added comprehensive test infrastructure for SBS functionality
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| ios/Classes/CountlyiOS/CountlyServerConfig.m | Core implementation of SBS merging logic and configuration handling |
| ios/Classes/CountlyiOS/CountlyPersistency.m | Updated storage methods to use NSMutableDictionary for server config |
| ios/Classes/CountlyFlutterPlugin.m | Added test helper methods for server config manipulation |
| example/integration_test/utils.dart | Enhanced test utilities with server config and event recording helpers |
| example/integration_test/sbs_tests/ | Comprehensive test suite covering various SBS scenarios and edge cases |
| android/src/main/java/.../CountlyFlutterPlugin.java | Added Android test helper methods for server config |
android/src/main/java/ly/count/dart/countly_flutter/CountlyFlutterPlugin.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tterPlugin.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.