Skip to content

[SER-2499] [crashes] Fix trend and change calculation #6479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
widatama merged 4 commits into from
Jul 28, 2025
Merged

[SER-2499] [crashes] Fix trend and change calculation #6479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c0d280
[crashes] Fix trend and change calculation
widatama Jul 27, 2025
db3f60c
Update changelog
widatama Jul 28, 2025
17219fa
Update crashes.js
can-angun Jul 28, 2025
6d88fca
Updated home page crash value verifies
can-angun Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Fixes:
- [core] Use correct rights validation for loyality
- [crashes] Fix free session for home widget
- [crashes] Use na for free session and free user when there's no data
- [crashes] Fix trend and change calculation for crash stats

Enterprise Fixes:
- [ldap] Error handling in ldap plugin on search error
Expand Down
8 changes: 7 additions & 1 deletion plugins/crashes/frontend/public/javascripts/countly.models.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,12 +169,18 @@ function transformAppVersion(inpVersion) {
else if (dashboard[metric].total !== 0 && dashboard[metric]["prev-total"] === 0) {
dashboard[metric].change = "∞";
}
else if (dashboard[metric].total === dashboard[metric]["prev-total"]) {
dashboard[metric].change = "0";
}

if (dashboard[metric].total === dashboard[metric]["prev-total"]) {
dashboard[metric].trend = "n";
}
else {
dashboard[metric].trend = dashboard[metric].total >= dashboard[metric]["prev-total"] ? "u" : "d";
var totl = dashboard[metric].total === 'NA' ? -1 : dashboard[metric].total;
var prevTotl = dashboard[metric]['prev-total'] === 'NA' ? -1 : dashboard[metric]['prev-total'];

dashboard[metric].trend = totl >= prevTotl ? 'u' : 'd';
}

if (metric in derivations) {
Expand Down
14 changes: 7 additions & 7 deletions ui-tests/cypress/lib/dashboard/crashes/crashes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ const verifyCrashStatisticsEChartElements = ({

cy.verifyElement({
labelElement: crashStatisticsEChartElements.TOTAL_OCCURENCES_CHANGE_VALUE_LABEL,
labelText: "NA",
labelText: "0",
});

cy.verifyElement({
Expand All @@ -573,7 +573,7 @@ const verifyCrashStatisticsEChartElements = ({

cy.verifyElement({
labelElement: crashStatisticsEChartElements.TOTAL_OCCURENCES_CHANGE_VALUE_LABEL,
labelText: "NA",
labelText: "0",
});

cy.verifyElement({
Expand All @@ -583,22 +583,22 @@ const verifyCrashStatisticsEChartElements = ({

cy.verifyElement({
labelElement: crashStatisticsEChartElements.CRASH_FREE_USERS_NUMBER_LABEL,
labelText: "100.00%",
labelText: "NA",
});

cy.verifyElement({
labelElement: crashStatisticsEChartElements.CRASH_FREE_USERS_CHANGE_VALUE_LABEL,
labelText: "0.0%",
labelText: "NA",
});

cy.verifyElement({
labelElement: crashStatisticsEChartElements.CRASH_FREE_SESSIONS_NUMBER_LABEL,
labelText: "100.00%",
labelText: "NA",
});

cy.verifyElement({
labelElement: crashStatisticsEChartElements.CRASH_FREE_SESSIONS_CHANGE_VALUE_LABEL,
labelText: "0.0%",
labelText: "NA",
});
return;
}
Expand Down Expand Up @@ -686,4 +686,4 @@ module.exports = {
verifyCrashGroupsDataFromTable,
verifyCrashStatisticsMetricCard,
verifyCrashStatisticsEChartElements
};
};
14 changes: 7 additions & 7 deletions ui-tests/cypress/lib/dashboard/home/home.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ const verifyEmptyPageElements = () => {

cy.verifyElement({
element: homePageElements.CRASH_STATISTICS.TOTAL_CRASHES_TREND_VALUE,
elementText: "NA",
elementText: "0",
});

cy.verifyElement({
Expand All @@ -498,7 +498,7 @@ const verifyEmptyPageElements = () => {

cy.verifyElement({
element: homePageElements.CRASH_STATISTICS.UNIQUE_CRASHES_TREND_VALUE,
elementText: "NA",
elementText: "0",
});

cy.verifyElement({
Expand All @@ -512,7 +512,7 @@ const verifyEmptyPageElements = () => {

cy.verifyElement({
element: homePageElements.CRASH_STATISTICS.CRASH_FREE_USERS_NUMBER,
elementText: "100.00%",
elementText: "NA",
});

cy.verifyElement({
Expand All @@ -521,12 +521,12 @@ const verifyEmptyPageElements = () => {

cy.verifyElement({
element: homePageElements.CRASH_STATISTICS.CRASH_FREE_USERS_TREND_VALUE,
elementText: "0.0%",
elementText: "NA",
});

cy.verifyElement({
element: homePageElements.CRASH_STATISTICS.CRASH_FREE_SESSIONS_NUMBER,
elementText: "100.00%",
elementText: "NA",
});

cy.verifyElement({
Expand All @@ -535,7 +535,7 @@ const verifyEmptyPageElements = () => {

cy.verifyElement({
element: homePageElements.CRASH_STATISTICS.CRASH_FREE_SESSIONS_TREND_VALUE,
elementText: "0.0%",
elementText: "NA",
});
};

Expand Down Expand Up @@ -806,4 +806,4 @@ const verifyFullDataPageElements = () => {
module.exports = {
verifyEmptyPageElements,
verifyFullDataPageElements
};
};
Loading