Skip to content

[push] Show segmentation, geo and cohorts related components in push drawer on editing draft.#6487

Merged
Cookiezaurs merged 2 commits intomasterfrom
anna/master
Jul 29, 2025
Merged

[push] Show segmentation, geo and cohorts related components in push drawer on editing draft.#6487
Cookiezaurs merged 2 commits intomasterfrom
anna/master

Conversation

@Cookiezaurs
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables display of segmentation, geo, and cohorts components in the push notification drawer when editing drafts by setting feature availability flags based on the presence of global objects.

  • Sets isEe, isGeo, and isCohorts flags on the response object to indicate feature availability
  • Enables conditional rendering of advanced targeting components in the push notification editor
Comments suppressed due to low confidence (3)

plugins/push/frontend/public/javascripts/countly.views.js:1126

  • The property name 'isEe' is ambiguous and unclear. Consider renaming it to 'isSegmentationAvailable' or 'hasSegmentation' to better indicate what feature it represents.
                        response.isEe = (typeof countlySegmentation !== 'undefined');

plugins/push/frontend/public/javascripts/countly.views.js:1127

  • The property name 'isGeo' is too generic. Consider renaming it to 'isGeoTargetingAvailable' or 'hasGeoTargeting' to clearly indicate its purpose.
                        response.isGeo = (typeof countlyLocationTargetComponent !== 'undefined');

plugins/push/frontend/public/javascripts/countly.views.js:1128

  • The property name 'isCohorts' should be renamed to 'isCohortsAvailable' or 'hasCohortsSupport' to be more descriptive and consistent with boolean naming conventions.
                        response.isCohorts = (typeof countlyCohorts !== 'undefined');

@Cookiezaurs Cookiezaurs merged commit 967b8ef into master Jul 29, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants