[push] Show segmentation, geo and cohorts related components in push drawer on editing draft.#6487
Merged
Cookiezaurs merged 2 commits intomasterfrom Jul 29, 2025
Merged
[push] Show segmentation, geo and cohorts related components in push drawer on editing draft.#6487Cookiezaurs merged 2 commits intomasterfrom
Cookiezaurs merged 2 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables display of segmentation, geo, and cohorts components in the push notification drawer when editing drafts by setting feature availability flags based on the presence of global objects.
- Sets
isEe,isGeo, andisCohortsflags on the response object to indicate feature availability - Enables conditional rendering of advanced targeting components in the push notification editor
Comments suppressed due to low confidence (3)
plugins/push/frontend/public/javascripts/countly.views.js:1126
- The property name 'isEe' is ambiguous and unclear. Consider renaming it to 'isSegmentationAvailable' or 'hasSegmentation' to better indicate what feature it represents.
response.isEe = (typeof countlySegmentation !== 'undefined');
plugins/push/frontend/public/javascripts/countly.views.js:1127
- The property name 'isGeo' is too generic. Consider renaming it to 'isGeoTargetingAvailable' or 'hasGeoTargeting' to clearly indicate its purpose.
response.isGeo = (typeof countlyLocationTargetComponent !== 'undefined');
plugins/push/frontend/public/javascripts/countly.views.js:1128
- The property name 'isCohorts' should be renamed to 'isCohortsAvailable' or 'hasCohortsSupport' to be more descriptive and consistent with boolean naming conventions.
response.isCohorts = (typeof countlyCohorts !== 'undefined');
cihadtekin
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.