Skip to content

fix: [deletion-manager] log & retry implementation for mongo deletion #6840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pnrgenc merged 1 commit into from
Oct 22, 2025
Merged

fix: [deletion-manager] log & retry implementation for mongo deletion #6840

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions api/jobs/deletionManagerJob.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,15 +280,19 @@ class DeletionManagerJob extends Job {
}

let res;
const start = Date.now();
try {
res = await common.drillDb.collection(task.collection).deleteMany(task.query || {});
}
catch (err) {
await this.markFailedOrRetry(task, "mongo_delete_error: " + err?.message || err + "");
const duration = Date.now() - start;
log.e("Mongo deletion failed", { taskId: task._id, durationMs: duration, error: (err?.message || err + "") });
await this.markFailedOrRetry(task, "mongo_delete_error: " + (err?.message || err + ""));
return false;
}

log.d("Mongo deletion done", { taskId: task._id, deletedCount: res?.deletedCount || 0 });
const duration = Date.now() - start;
log.d("Mongo deletion done", { taskId: task._id, deletedCount: res?.deletedCount || 0, durationMs: duration });
return true;
}

Expand Down
Loading