Skip to content

[push] Better FCM error handling #7043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cihadtekin merged 1 commit into from
Dec 9, 2025
Merged

[push] Better FCM error handling #7043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions plugins/push/api/send/platforms/a.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,19 +188,30 @@ class FCM extends Splitter {
sentSuccessfully.push({ p: allPushIds[i], r: messageId });
}
else {
const sdkError = FCM_SDK_ERRORS[error.code];
// check if the sdk error is mapped to an internal error.
// set to default if its not.
let internalErrorCode = sdkError?.mapTo ?? ERROR.DATA_PROVIDER;
let internalErrorMessage = sdkError?.message;
if (!internalErrorMessage) {
if (error.code && error.message) {
internalErrorMessage = "[" + error.code + "] " + error.message;
let internalErrorCode = ERROR.DATA_PROVIDER;
let internalErrorMessage = "Invalid error message";
let mapped = false;

// valid error object (it could be undefined based on its type definition)
if (error && error.code && error.message) {
// check if the sdk error is mapped to an internal error.
if (error.code in FCM_SDK_ERRORS) {
const sdkError = FCM_SDK_ERRORS[error.code];
if (sdkError.mapTo) {
internalErrorCode = sdkError.mapTo;
}
internalErrorMessage = sdkError.libraryKey + ": " + sdkError.message;
mapped = true;
}
else {
internalErrorMessage = "Invalid error message";
internalErrorMessage = "[" + error.code + "] " + error.message;
}
}

if (!mapped) {
this.log.e("Unrecognized FCM error", result.responses[i]);
}

errorObject(internalErrorCode, internalErrorMessage)
.addAffected(pushes[i]._id, one);
}
Expand Down
Loading